Skip to content

Commit 7737611

Browse files
samuelmeulimastilver
authored andcommitted
Fix entrypoints compatibility for older Node versions (#194)
* Fix `entrypoints` compatibility for older Node versions * Use `object.entries` package
1 parent 687e260 commit 7737611

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

lib/plugin.js

+6-5
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
var entries = require('object.entries');
12
var path = require('path');
23
var fse = require('fs-extra');
34
var _ = require('lodash');
@@ -166,12 +167,12 @@ ManifestPlugin.prototype.apply = function(compiler) {
166167
// Webpack 4+
167168
compilation.entrypoints.entries() :
168169
// Webpack 3
169-
Object.entries(compilation.entrypoints)
170+
entries(compilation.entrypoints)
171+
);
172+
const entrypoints = entrypointsArray.reduce(
173+
(e, [name, entrypoint]) => Object.assign(e, { [name]: entrypoint.getFiles() }),
174+
{}
170175
);
171-
const entrypoints = entrypointsArray.reduce((e, [name, entrypoint]) => ({
172-
...e,
173-
[name]: entrypoint.getFiles()
174-
}), {});
175176
manifest = this.opts.generate(seed, files, entrypoints);
176177
} else {
177178
manifest = files.reduce(function (manifest, file) {

package.json

+1
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@
4343
"dependencies": {
4444
"fs-extra": "^7.0.0",
4545
"lodash": ">=3.5 <5",
46+
"object.entries": "^1.1.0",
4647
"tapable": "^1.0.0"
4748
},
4849
"jest": {

spec/plugin.spec.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -756,10 +756,10 @@ describe('ManifestPlugin', function() {
756756
{
757757
manifestOptions: {
758758
generate: (seed, files, entrypoints) => {
759-
const manifestFiles = files.reduce((manifest, { name, path }) => ({
760-
...manifest,
761-
[name]: path
762-
}), seed);
759+
const manifestFiles = files.reduce(
760+
(manifest, { name, path }) => Object.assign(manifest, { [name]: path }),
761+
seed
762+
);
763763
return {
764764
files: manifestFiles,
765765
entrypoints

0 commit comments

Comments
 (0)