Skip to content

Commit e0dcba6

Browse files
authored
Merge pull request kubernetes-sigs#15 from shaneutt/fix-kustomize-envs
Fix kustomize envs
2 parents 0c4e6c8 + 950e07b commit e0dcba6

12 files changed

+10
-6
lines changed

Makefile

+10-6
Original file line numberDiff line numberDiff line change
@@ -513,6 +513,8 @@ uninstall-docker: check-container-tool ## Uninstall app from $(CONTAINER_TOOL)
513513

514514
### Kubernetes Targets (kubectl)
515515

516+
# TODO: currently incorrect because it depends on OpenShift APIs.
517+
# See: https://github.com/neuralmagic/gateway-api-inference-extension/issues/14
516518
.PHONY: install-k8s
517519
install-k8s: check-kubectl check-kustomize check-envsubst ## Install on Kubernetes
518520
export PROJECT_NAME=${PROJECT_NAME}
@@ -522,20 +524,22 @@ install-k8s: check-kubectl check-kustomize check-envsubst ## Install on Kubernet
522524
kubectl config set-context --current --namespace=$(NAMESPACE)
523525
@echo "Deploying resources from deploy/ ..."
524526
# Build the kustomization from deploy, substitute variables, and apply the YAML
525-
kustomize build deploy | envsubst | kubectl apply -f -
527+
kustomize build deploy/environments/openshift | envsubst | kubectl apply -f -
526528
@echo "Waiting for pod to become ready..."
527529
sleep 5
528530
@POD=$$(kubectl get pod -l app=$(PROJECT_NAME)-statefulset -o jsonpath='{.items[0].metadata.name}'); \
529531
echo "Kubernetes installation complete."; \
530532
echo "To use the app, run:"; \
531533
echo "alias $(PROJECT_NAME)='kubectl exec -n $(NAMESPACE) -it $$POD -- /app/$(PROJECT_NAME)'"
532534

535+
# TODO: currently incorrect because it depends on OpenShift APIs.
536+
# See: https://github.com/neuralmagic/gateway-api-inference-extension/issues/14
533537
.PHONY: uninstall-k8s
534538
uninstall-k8s: check-kubectl check-kustomize check-envsubst ## Uninstall from Kubernetes
535539
export PROJECT_NAME=${PROJECT_NAME}
536540
export NAMESPACE=${NAMESPACE}
537541
@echo "Removing resources from Kubernetes..."
538-
kustomize build deploy | envsubst | kubectl delete --force -f - || true
542+
kustomize build deploy/environments/openshift | envsubst | kubectl delete --force -f - || true
539543
POD=$$(kubectl get pod -l app=$(PROJECT_NAME)-statefulset -o jsonpath='{.items[0].metadata.name}'); \
540544
echo "Deleting pod: $$POD"; \
541545
kubectl delete pod "$$POD" --force --grace-period=0 || true; \
@@ -550,7 +554,7 @@ install-openshift: check-kubectl check-kustomize check-envsubst ## Install on Op
550554
kubectl create namespace $(NAMESPACE) 2>/dev/null || true
551555
@echo "Deploying common resources from deploy/ ..."
552556
# Build and substitute the base manifests from deploy, then apply them
553-
kustomize build deploy | envsubst '$$PROJECT_NAME $$NAMESPACE $$IMAGE_TAG_BASE $$VERSION' | kubectl apply -n $(NAMESPACE) -f -
557+
kustomize build deploy/environments/openshift | envsubst '$$PROJECT_NAME $$NAMESPACE $$IMAGE_TAG_BASE $$VERSION' | kubectl apply -n $(NAMESPACE) -f -
554558
@echo "Waiting for pod to become ready..."
555559
sleep 5
556560
@POD=$$(kubectl get pod -l app=$(PROJECT_NAME)-statefulset -n $(NAMESPACE) -o jsonpath='{.items[0].metadata.name}'); \
@@ -561,7 +565,7 @@ install-openshift: check-kubectl check-kustomize check-envsubst ## Install on Op
561565
.PHONY: uninstall-openshift
562566
uninstall-openshift: check-kubectl check-kustomize check-envsubst ## Uninstall from OpenShift
563567
@echo "Removing resources from OpenShift..."
564-
kustomize build deploy | envsubst '$$PROJECT_NAME $$NAMESPACE $$IMAGE_TAG_BASE $$VERSION' | kubectl delete --force -f - || true
568+
kustomize build deploy/environments/openshift | envsubst '$$PROJECT_NAME $$NAMESPACE $$IMAGE_TAG_BASE $$VERSION' | kubectl delete --force -f - || true
565569
# @if kubectl api-resources --api-group=route.openshift.io | grep -q Route; then \
566570
# envsubst '$$PROJECT_NAME $$NAMESPACE $$IMAGE_TAG_BASE $$VERSION' < deploy/openshift/route.yaml | kubectl delete --force -f - || true; \
567571
# fi
@@ -575,12 +579,12 @@ uninstall-openshift: check-kubectl check-kustomize check-envsubst ## Uninstall f
575579
.PHONY: install-rbac
576580
install-rbac: check-kubectl check-kustomize check-envsubst ## Install RBAC
577581
@echo "Applying RBAC configuration from deploy/rbac..."
578-
kustomize build deploy/rbac | envsubst '$$PROJECT_NAME $$NAMESPACE $$IMAGE_TAG_BASE $$VERSION' | kubectl apply -f -
582+
kustomize build deploy/environments/openshift/rbac | envsubst '$$PROJECT_NAME $$NAMESPACE $$IMAGE_TAG_BASE $$VERSION' | kubectl apply -f -
579583

580584
.PHONY: uninstall-rbac
581585
uninstall-rbac: check-kubectl check-kustomize check-envsubst ## Uninstall RBAC
582586
@echo "Removing RBAC configuration from deploy/rbac..."
583-
kustomize build deploy/rbac | envsubst '$$PROJECT_NAME $$NAMESPACE $$IMAGE_TAG_BASE $$VERSION' | kubectl delete -f - || true
587+
kustomize build deploy/environments/openshift/rbac | envsubst '$$PROJECT_NAME $$NAMESPACE $$IMAGE_TAG_BASE $$VERSION' | kubectl delete -f - || true
584588

585589

586590
##@ Version Extraction

0 commit comments

Comments
 (0)