Skip to content

Commit 4977e5f

Browse files
authored
Merge pull request kubernetes-retired#1 from wlan0/fix-bug
Pass by-ref instead of by-value
2 parents aaad0b1 + f93cc49 commit 4977e5f

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

container-object-storage-interface-provisioner-sidecar/pkg/controller/bucketaccess/bucket_access_controller.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ func (bal *bucketAccessListener) Add(ctx context.Context, obj *v1alpha1.BucketAc
149149
// Only update the principal in the BucketAccess if it wasn't set because
150150
// that means that the provisioner created one
151151
if len(obj.Spec.Principal) == 0 {
152-
err = bal.updatePrincipal(ctx, obj.Name, *rsp)
152+
err = bal.updatePrincipal(ctx, obj.Name, rsp)
153153
if err != nil {
154154
return err
155155
}
@@ -260,7 +260,7 @@ func (bal *bucketAccessListener) updateStatus(ctx context.Context, name, msg str
260260
return err
261261
}
262262

263-
func (bal *bucketAccessListener) updatePrincipal(ctx context.Context, name string, resp osspec.ProvisionerGrantBucketAccessResponse) error {
263+
func (bal *bucketAccessListener) updatePrincipal(ctx context.Context, name string, resp *osspec.ProvisionerGrantBucketAccessResponse) error {
264264
err := retry.RetryOnConflict(retry.DefaultRetry, func() error {
265265
bucketAccess, err := bal.bucketAccessClient.ObjectstorageV1alpha1().BucketAccesses().Get(ctx, name, metav1.GetOptions{})
266266
if err != nil {

0 commit comments

Comments
 (0)