Skip to content

Commit 0022278

Browse files
committed
Fixing build for the api changes to Protocol
1 parent 2276b7b commit 0022278

File tree

5 files changed

+8
-22
lines changed

5 files changed

+8
-22
lines changed

container-object-storage-interface-controller/go.mod

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ require (
99
github.com/google/uuid v1.1.2 // indirect
1010
github.com/gopherjs/gopherjs v0.0.0-20190328170749-bb2674552d8f // indirect
1111
github.com/kr/text v0.2.0 // indirect
12-
github.com/kubernetes-sigs/container-object-storage-interface-api v0.0.0-20201210173615-0c3244fa34b9
12+
github.com/kubernetes-sigs/container-object-storage-interface-api v0.0.0-20210120011359-1e91ae41e243
1313
github.com/mailru/easyjson v0.7.6 // indirect
1414
github.com/niemeyer/pretty v0.0.0-20200227124842-a10e7caefd8e // indirect
1515
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect

container-object-storage-interface-controller/go.sum

+2-2
Original file line numberDiff line numberDiff line change
@@ -303,8 +303,8 @@ github.com/kr/text v0.1.0 h1:45sCR5RtlFHMR4UwH9sdQ5TC8v0qDQCHnXt+kaKSTVE=
303303
github.com/kr/text v0.1.0/go.mod h1:4Jbv+DJW3UT/LiOwJeYQe1efqtUx/iVham/4vfdArNI=
304304
github.com/kr/text v0.2.0 h1:5Nx0Ya0ZqY2ygV366QzturHI13Jq95ApcVaJBhpS+AY=
305305
github.com/kr/text v0.2.0/go.mod h1:eLer722TekiGuMkidMxC/pM04lWEeraHUUmBw8l2grE=
306-
github.com/kubernetes-sigs/container-object-storage-interface-api v0.0.0-20201210173615-0c3244fa34b9 h1:1Zmlu1GKd1iIv9fdc1mkaTuUtoNqet4NLYLE/8p9ylw=
307-
github.com/kubernetes-sigs/container-object-storage-interface-api v0.0.0-20201210173615-0c3244fa34b9/go.mod h1:C7tjzC+nLe7H7+3UM/Z6a7F24yxOO8FSK3ZaVZrKDPQ=
306+
github.com/kubernetes-sigs/container-object-storage-interface-api v0.0.0-20210120011359-1e91ae41e243 h1:iOEsQYg/QXxzYP10JaLtoQWdlGG3OS/a3sOYsrDXwdE=
307+
github.com/kubernetes-sigs/container-object-storage-interface-api v0.0.0-20210120011359-1e91ae41e243/go.mod h1:C7tjzC+nLe7H7+3UM/Z6a7F24yxOO8FSK3ZaVZrKDPQ=
308308
github.com/magiconair/properties v1.8.0/go.mod h1:PppfXfuXeibc/6YijjN8zIbojt8czPbwD3XqdrwzmxQ=
309309
github.com/magiconair/properties v1.8.1 h1:ZC2Vc7/ZFkGmsVC9KvOjumD+G5lXy2RtTKyzRKO2BQ4=
310310
github.com/magiconair/properties v1.8.1/go.mod h1:PppfXfuXeibc/6YijjN8zIbojt8czPbwD3XqdrwzmxQ=

container-object-storage-interface-controller/pkg/bucketaccessrequest/bucketaccessrequest_test.go

+1-5
Original file line numberDiff line numberDiff line change
@@ -71,11 +71,7 @@ var bucketRequest1 = types.BucketRequest{
7171
UID: "br-12345",
7272
},
7373
Spec: types.BucketRequestSpec{
74-
BucketPrefix: "cosi",
75-
Protocol: types.RequestedProtocol{
76-
Name: "s3",
77-
Version: "",
78-
},
74+
BucketPrefix: "cosi",
7975
BucketClassName: "classgold",
8076
BucketInstanceName: "cosi1234567890",
8177
},

container-object-storage-interface-controller/pkg/bucketrequest/bucketrequest.go

+1-3
Original file line numberDiff line numberDiff line change
@@ -116,11 +116,9 @@ func (b *bucketRequestListener) provisionBucketRequestOperation(ctx context.Cont
116116
Namespace: bucketRequest.Namespace,
117117
UID: bucketRequest.ObjectMeta.UID}
118118
bucket.Spec.AllowedNamespaces = util.CopyStrings(bucketClass.AllowedNamespaces)
119+
bucket.Spec.Protocol = *bucketClass.Protocol.DeepCopy()
119120
bucket.Spec.Parameters = util.CopySS(bucketClass.Parameters)
120121

121-
// TODO have a switch statement to populate appropriate protocol based on BR.Protocol
122-
bucket.Spec.Protocol.RequestedProtocol = bucketRequest.Spec.Protocol
123-
124122
bucket, err = b.bucketClient.ObjectstorageV1alpha1().Buckets().Create(context.Background(), bucket, metav1.CreateOptions{})
125123
if err != nil {
126124
if errors.IsAlreadyExists(err) {

container-object-storage-interface-controller/pkg/bucketrequest/bucketrequest_test.go

+3-11
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ var goldClass = types.BucketClass{
2828
},
2929
AllowedNamespaces: []string{"default", "cosins"},
3030
Parameters: classGoldParameters,
31-
Protocol: "s3",
31+
Protocol: types.Protocol{Name: "s3"},
3232
IsDefaultBucketClass: false,
3333
}
3434

@@ -43,11 +43,7 @@ var bucketRequest1 = types.BucketRequest{
4343
UID: "12345-67890",
4444
},
4545
Spec: types.BucketRequestSpec{
46-
BucketPrefix: "cosi",
47-
Protocol: types.RequestedProtocol{
48-
Name: "s3",
49-
Version: "",
50-
},
46+
BucketPrefix: "cosi",
5147
BucketClassName: "classgold",
5248
},
5349
}
@@ -63,11 +59,7 @@ var bucketRequest2 = types.BucketRequest{
6359
UID: "abcde-fghijk",
6460
},
6561
Spec: types.BucketRequestSpec{
66-
BucketPrefix: "cosi",
67-
Protocol: types.RequestedProtocol{
68-
Name: "s3",
69-
Version: "",
70-
},
62+
BucketPrefix: "cosi",
7163
BucketClassName: "classgold",
7264
},
7365
}

0 commit comments

Comments
 (0)