Skip to content

Commit 24432ae

Browse files
committed
enhance turbo/links tracing messages
1 parent 29ebe20 commit 24432ae

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

node_package/src/clientStartup.ts

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -196,8 +196,8 @@ function parseRailsContext(): RailsContext | null {
196196
return JSON.parse(el.textContent);
197197
}
198198

199-
export function reactOnRailsPageLoaded(): void {
200-
debugTurbolinks('reactOnRailsPageLoaded');
199+
export function reactOnRailsPageLoaded(reason: string): void {
200+
debugTurbolinks(`reactOnRailsPageLoaded because ${reason}`);
201201

202202
const railsContext = parseRailsContext();
203203

@@ -220,8 +220,8 @@ function unmount(el: Element): void {
220220
}
221221
}
222222

223-
function reactOnRailsPageUnloaded(): void {
224-
debugTurbolinks('reactOnRailsPageUnloaded');
223+
function reactOnRailsPageUnloaded(reason: string): void {
224+
debugTurbolinks(`reactOnRailsPageUnloaded because ${reason}`);
225225
const els = reactOnRailsHtmlElements();
226226
for (let i = 0; i < els.length; i += 1) {
227227
unmount(els[i]);
@@ -234,30 +234,30 @@ function renderInit(): void {
234234
// Webpack bundles first.
235235
if ((!turbolinksInstalled() || !turbolinksSupported()) && !turboInstalled()) {
236236
debugTurbolinks('NOT USING TURBOLINKS: calling reactOnRailsPageLoaded');
237-
reactOnRailsPageLoaded();
237+
reactOnRailsPageLoaded('nothing:default');
238238
return;
239239
}
240240

241241
if (turboInstalled()) {
242242
debugTurbolinks(
243243
'USING TURBO: document added event listeners ' +
244244
'turbo:before-render and turbo:render.');
245-
document.addEventListener('turbo:before-render', reactOnRailsPageUnloaded);
246-
document.addEventListener('turbo:render', reactOnRailsPageLoaded);
247-
reactOnRailsPageLoaded();
245+
document.addEventListener('turbo:before-render', reactOnRailsPageUnloaded('turbo:before-render'));
246+
document.addEventListener('turbo:render', reactOnRailsPageLoaded('turbo:render'));
247+
reactOnRailsPageLoaded('turbo:default');
248248
} else if (turbolinksVersion5()) {
249249
debugTurbolinks(
250250
'USING TURBOLINKS 5: document added event listeners ' +
251251
'turbolinks:before-render and turbolinks:render.');
252-
document.addEventListener('turbolinks:before-render', reactOnRailsPageUnloaded);
253-
document.addEventListener('turbolinks:render', reactOnRailsPageLoaded);
254-
reactOnRailsPageLoaded();
252+
document.addEventListener('turbolinks:before-render', reactOnRailsPageUnloaded('turbolinks:before-render'));
253+
document.addEventListener('turbolinks:render', reactOnRailsPageLoaded('turbolinks:render'));
254+
reactOnRailsPageLoaded('turbolinks:default');
255255
} else {
256256
debugTurbolinks(
257257
'USING TURBOLINKS 2: document added event listeners page:before-unload and ' +
258258
'page:change.');
259-
document.addEventListener('page:before-unload', reactOnRailsPageUnloaded);
260-
document.addEventListener('page:change', reactOnRailsPageLoaded);
259+
document.addEventListener('page:before-unload', reactOnRailsPageUnloaded('page:before-unload'));
260+
document.addEventListener('page:change', reactOnRailsPageLoaded('page:change'));
261261
}
262262
}
263263

0 commit comments

Comments
 (0)