eslint additions

Author: alexeuler

mobile/ReactNativeTutorial/.babelrc

@@ -1,3 +1,3 @@
 {
-"presets": ["react-native"]
-}
+  "presets": ["react-native"]
+}

mobile/ReactNativeTutorial/.eslintignore

@@ -1,4 +1,2 @@
-node_modules
 ios
 android
-.git

mobile/ReactNativeTutorial/.eslintrc.yml

@@ -1,10 +1,13 @@
 ---
   extends:
     - "eslint-config-shakacode"
+    - "plugin:lodash-fp/recommended"
+    - "plugin:flowtype/recommended"
   plugins:
     - "react-native"
     - "flowtype"
     - "babel"
+    - "lodash-fp"
 
   env:
     node: true
@@ -22,21 +25,14 @@
       onlyFilesWithFlowAnnotation: true
   globals:
     __DEV__: true
-    ReactClass: true
-    ReactElement: true
     fetch: true
   rules:
     new-cap: 0
-    react/sort-comp: 0
-    no-console: 0
-    import/imports-first: 2
-    import/prefer-default-export: 2
-    no-duplicate-imports: 0
+    react/sort-comp: 2
+    no-console: 2
 
     babel/no-await-in-loop: 1
 
-    # Delegating proptypes check to flow
-    react/prop-types: 0
     generator-star-spacing: 0
 
     react-native/no-unused-styles: 2
@@ -47,21 +43,3 @@
     react/jsx-filename-extension:
       - 1
       - extensions: [".js", ".jsx"]
-
-    flowtype/require-parameter-type: 1
-    flowtype/require-return-type:
-      - 0
-      - "always"
-      - annotateUndefined: "never"
-    flowtype/require-valid-file-annotation:
-      - 2
-      - "always"
-    flowtype/space-after-type-colon:
-      - 2
-      - "always"
-    flowtype/space-before-type-colon:
-      - 2
-      - "never"
-    flowtype/type-id-match:
-      - 2
-      - "^([A-Z][a-z0-9]+)+Type$"

mobile/ReactNativeTutorial/app/bundles/comments/effects/index.js

@@ -8,13 +8,12 @@ import { actions as reduxActions } from 'ReactNativeTutorial/app/reducers';
 import * as api from 'ReactNativeTutorial/app/api';
 
 export const fetch = () =>
-  async function fetchCommentsEffect(dispatch, _, { call }) {
+  async function fetchCommentsEffect(dispatch, _getState, { call }) {
     dispatch(reduxActions.setLoadingComments(true));
     let response;
     try {
       response = await call(api.fetchComments);
     } catch (e) {
-      call(console.log, e);
       call(Alert.alert, 'Error', 'Could not connect to server', [{ text: 'OK' }]);
       return;
     } finally {
@@ -39,7 +38,6 @@ export const createComment = () =>
     try {
       response = await call(api.postComment, comment);
     } catch (e) {
-      call(console.log, e);
       call(Alert.alert, 'Error', 'Could not post your comment', [{ text: 'OK' }]);
       return;
     } finally {

mobile/ReactNativeTutorial/app/setup/Router/Router.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-console */
 import React from 'react';
 import { Scene, Router, Reducer } from 'react-native-router-flux';
 import Add from '../../bundles/comments/containers/Add';

mobile/ReactNativeTutorial/app/setup/loggerMiddleware.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-console */
 import _ from 'lodash/fp';
 
 export default function logger({ getState }) {

mobile/ReactNativeTutorial/package.json

@@ -39,6 +39,7 @@
     "eslint-plugin-flowtype": "^2.25.0",
     "eslint-plugin-import": "^1.16.0",
     "eslint-plugin-jsx-a11y": "^2.2.3",
+    "eslint-plugin-lodash-fp": "^2.1.3",
     "eslint-plugin-react": "^6.7.1",
     "eslint-plugin-react-native": "^2.1.0",
     "flow-bin": "^0.33.0",