Skip to content

Commit d10203a

Browse files
committed
Respond to PR Review
1 parent 27ffd5c commit d10203a

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ You can see this tutorial live here: [http://reactrails.com/](http://reactrails.
2929

3030
In no particular order:
3131

32-
- Example of using the [react_on_rails](https://github.com/shakacode/react_on_rails) for easy react/webpack integration with Rails.
32+
- Example of using the [react_on_rails gem](https://github.com/shakacode/react_on_rails) for easy react/webpack integration with Rails.
3333
- Example of React with [CSS Modules](http://glenmaddern.com/articles/css-modules) inside of Rails using Webpack as described in [Smarter CSS builds with Webpack](http://bensmithett.com/smarter-css-builds-with-webpack/).
3434
- Example of enabling hot reloading of both JS and CSS from your Rails app in development mode. Change your code. Save. Browser updates without a refresh!
3535
- Example of Rails 4.2 with ReactJs/Redux/React-Router with Webpack and ES7.
@@ -45,6 +45,7 @@ See package.json and Gemfile for versions
4545
1. [react_on_rails gem](https://github.com/shakacode/react_on_rails/)
4646
1. [React](http://facebook.github.io/react/) (for front-end app)
4747
1. [react-bootstrap](https://react-bootstrap.github.io/)
48+
1. [bootstrap-loader](https://www.npmjs.com/package/bootstrap-loader/)
4849
1. [Redux](https://github.com/rackt/redux)
4950
1. [Webpack with hot-reload](https://github.com/webpack/docs/wiki/hot-module-replacement-with-webpack) (for local dev)
5051
1. [Babel transpiler](https://github.com/babel/babel)

docs/heroku.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# Deploying to Heroku
22

3+
First consult this article: [Using Multiple Buildpacks for an App](https://devcenter.heroku.com/articles/using-multiple-buildpacks-for-an-app).
4+
35
In order to deploy to heroku, you'll need to run this command once to set a custom
46
buildpack:
57

@@ -12,6 +14,8 @@ This runs the two buildpacks in the `.buildpacks` directory.
1214
Also make sure you are running the latest heroku stack, cedar-14, to avoid running
1315
into the [following issue](https://github.com/sass/node-sass/issues/467#issuecomment-61729195).
1416

17+
This is now the current default.
18+
1519
```
1620
heroku stack:set cedar-14 -a react-webpack-rails-tutorial
1721
```

0 commit comments

Comments
 (0)