PyCQA#129 - WIPlash

Author: shacharoo

src/pydocstyle/checker.py

@@ -456,19 +456,24 @@ def _check_section(cls, line_index, dashes_indices, lines):
             # meaning that the words appear there but not properly capitalized.
             yield violations.D405(actual_section, section)
 
-        if line.strip().endswith(":"):
-            # The section name should not end with a colon.
-            yield violations.D406(actual_section, line)
+        suffix = line.lstrip(section).strip()
+        if suffix:
+            # The section name should end with a newline.
+            yield violations.D406(actual_section, suffix)
 
         next_line_index = line_index + 1
         if next_line_index not in dashes_indices:
             yield violations.D407(actual_section)
         else:
+            next_line_index += 1
             if lines[next_line_index].strip() != "-" * len(section):
                 # The length of the underlining dashes does not
                 # match the length of the section name.
                 yield violations.D408(section, len(section))
 
+        if lines[next_line_index].strip():
+            yield violations.D409(actual_section)
+
     @check_for(Definition)
     def check_docstring_internal_structure(self, definition, docstring):
         """Parse the general structure of a numpy docstring and check it."""

src/pydocstyle/violations.py

@@ -210,12 +210,13 @@ def to_rst(cls):
                                  'be `This`')
 D405 = D4xx.create_error('D405', 'Section name should be properly capitalized',
                          '{0!r}, not {1!r}')
-D406 = D4xx.create_error('D406', 'Section name should not end with a colon',
-                         '{0!r}, not {1!r}')
+D406 = D4xx.create_error('D406', 'Section name should end with a newline',
+                         '{0!r}, found {1!r}')
 D407 = D4xx.create_error('D407', 'Missing dashed underline after section name',
                          'section={0!r}')
 D408 = D4xx.create_error('D408', 'Section underline should match the length '
                          'of the section\'s name', 'len({0!r}) == {1!r}')
+D409 = D4xx.create_error('D409', 'Missing blank line after section', '{0!r}')
 
 
 class AttrDict(dict):