Implement Copy and Clone for Handle<T> where T: !Copy (#563)

gmorenz · web-flow · commit ca234a380a1a · 2025-03-22T14:28:09.000Z
Signed-off-by: Greg Morenz &lt;greg-morenz@droid.cafe&gt;
diff --git a/mozjs/src/gc/root.rs b/mozjs/src/gc/root.rs
@@ -95,11 +95,18 @@ impl<'a, const N: usize> From<&RootedGuard<'a, ValueArray<N>>> for JS::HandleVal
     }
 }
 
-#[derive(Clone, Copy)]
 pub struct Handle<'a, T: 'a> {
     pub(crate) ptr: &'a T,
 }
 
+impl<T> Clone for Handle<'_, T> {
+    fn clone(&self) -> Self {
+        *self
+    }
+}
+
+impl<T> Copy for Handle<'_, T> {}
+
 #[derive(Copy, Clone)]
 pub struct MutableHandle<'a, T: 'a> {
     pub(crate) ptr: *mut T,

Original file line number	Diff line number	Diff line change
`@@ -95,11 +95,18 @@ impl<'a, const N: usize> From<&RootedGuard<'a, ValueArray<N>>> for JS::HandleVal`
`95`	`95`	`}`
`96`	`96`	`}`
`97`	`97`
`98`		`-#[derive(Clone, Copy)]`
`99`	`98`	`pub struct Handle<'a, T: 'a> {`
`100`	`99`	`pub(crate) ptr: &'a T,`
`101`	`100`	`}`
`102`	`101`
	`102`	`+impl<T> Clone for Handle<'_, T> {`
	`103`	`+ fn clone(&self) -> Self {`
	`104`	`+ *self`
	`105`	`+ }`
	`106`	`+}`
	`107`	`+`
	`108`	`+impl<T> Copy for Handle<'_, T> {}`
	`109`	`+`
`103`	`110`	`#[derive(Copy, Clone)]`
`104`	`111`	`pub struct MutableHandle<'a, T: 'a> {`
`105`	`112`	`pub(crate) ptr: *mut T,`