Speed up requirements installation by skipping noDeploy #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of filtering later, just don't install them
kichik
added a commit
to kichik/serverless-python-requirements
that referenced
this pull request
Feb 28, 2018
serverless#146 already takes care of this, but we need proper noDeploy here again in case a white-listed package is dependent on a black-listed package
|
Hah. That's how this was initially implemented. Not sure why it was changed. I'll have to go back and review that to see if I had a good reason and if that's still applicable. |
|
I haven't seen the change, but I would assume it happened because |
|
Yeah, that makes sense. |
dschep
approved these changes
Mar 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of filtering later, just don't install them