Skip to content

No need to mess with zip #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Suor opened this issue Nov 5, 2018 · 1 comment
Closed

No need to mess with zip #275

Suor opened this issue Nov 5, 2018 · 1 comment

Comments

@Suor
Copy link

Suor commented Nov 5, 2018

The process of adding requirements looks needlessly complicated with zipping. It's enough to copy or symlink requirements to target dir in before:package:createDeploymentArtifacts and remove in after:package:createDeploymentArtifacts.

This is also really slow.
@dschep
Copy link
Contributor

dschep commented Nov 5, 2018 •
edited
Loading

That is in fact how it was implemented in the past. see #147 for the various reasons for changing

@dschep dschep closed this as completed Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Suor @dschep