Feature request: Add pre/post command for docker build

[rokoroku]

In case of a dependency that requires native binaries before pip install command,
so currently I'm handling it like this way:

    pythonBin: >-
      curl --silent -L https://example.com/source.tar.gz | tar xzf &&
      docker run -v "$(pwd):/var/task:z" -u 0 sls-py-reqs-custom ./source/make install &&
      docker run -v "$(pwd):/var/task:z" -u 0 sls-py-reqs-custom python3
    pipCmdExtraArgs:
      - && docker run --rm -v "$(pwd):/var/task:z" -u 0 cp -R /build .serverless/requirements   

but if we have something like preDockerCmd / postDockerCmd, we can achieve it like this way:

    preDockerCmd:
      - curl --silent -L https://example.com/source.tar.gz | tar xzf
      - ./source/make install

    postDockerCmd:
      - cp -R /build .serverless/requirements   

reference:

https://stackoverflow.com/a/26274399/2305379

[dschep]

Not a bad idea. For situations like yours where you seem to be ok with separate docker run invocations, it might make sense to add have the plugin fire off custom lifecycle events which can then be more easily tapped into with plugins like serverless-plugin-scripts.

then you could (with that plugin) do something like this:

custom:
  scripts:
    hooks:
      'before:requirements:pip:install': curl --silent -L https://example.com/source.tar.gz | tar xzf && docker run -v "$(pwd):/var/task:z" -u 0 sls-py-reqs-custom ./source/make install
      'after:requirements:pip:install': cp -R /build .serverless/requirements

[rokoroku]

@dschep Yeah but things like sls-py-reqs-custom and .serverless/requirements is kind of a hack into serverless-python-requirements's internal (which means they might be highly likely changed without any announcement.)

So it's better to have that hooks with custom.pythonRequirements variable.
I think it can be applied to both docker / without docker environment

e.g.

custom:
  pythonRequirements:
    # hooks can be applied to both environment with/without docker
    hooks:
       # accepting both string or string array 
      'before:requirements:pip:install': ...
      'after:requirements:pip:install': 
         - ...
         - ...

[MrTeale]

+1 on this. Are there any updates on if we'll see this in the near future?

[dschep]

@MrTeale, AFAIK no one is working on this. Sorry.

[pgrzesik]

Hey 👋 I'm closing this ticket as it looks like it's heavily outdated, we can of course reopen it if needed 👍