Correct imprecise regex in moveModuleUp function (fixes #444)

Jim Pudar · Jim Pudar · commit 6f1a8843beb0 · 2020-01-07T16:31:26.000-05:00
The existing regex had the side effect of matching python files
from other modules if their filename or path happened to contain
the string `s_`.
diff --git a/lib/inject.js b/lib/inject.js
@@ -67,7 +67,7 @@ function moveModuleUp(source, target, module) {
         file =>
           file.startsWith(module + '/') ||
           file.startsWith('serverless_sdk/') ||
-          file.match(/s_.*\.py/) !== null
+          file.match(/^s_.*\.py/) !== null
       )
     )
     .map(srcZipObj =>

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ function moveModuleUp(source, target, module) {`
`67`	`67`	`file =>`
`68`	`68`	`file.startsWith(module + '/') \|\|`
`69`	`69`	`file.startsWith('serverless_sdk/') \|\|`
`70`		`- file.match(/s_.*\.py/) !== null`
	`70`	`+ file.match(/^s_.*\.py/) !== null`
`71`	`71`	`)`
`72`	`72`	`)`
`73`	`73`	`.map(srcZipObj =>`