Skip to content

Commit 6631248

Browse files
jaysonsantosdschep
andcommitted
Apply suggestions from code review
Co-Authored-By: Daniel Schep <[email protected]>
1 parent 2c6b3c1 commit 6631248

File tree

2 files changed

+3
-8
lines changed

2 files changed

+3
-8
lines changed

lib/poetry.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -33,19 +33,19 @@ function pyprojectTomlToRequirements() {
3333
throw new Error(res.stderr);
3434
}
3535

36-
const editableLine = new RegExp(/^-e /gm);
36+
const editableFlag = new RegExp(/^-e /gm);
3737
const sourceRequirements = path.join(this.servicePath, 'requirements.txt');
3838
const requirementsContents = fse.readFileSync(sourceRequirements, {
3939
encoding: 'utf-8'
4040
});
4141

42-
if (requirementsContents.match(editableLine)) {
42+
if (requirementsContents.match(editableFlag)) {
4343
this.serverless.cli.log(
4444
'The generated file contains -e lines, removing them...'
4545
);
4646
fse.writeFileSync(
4747
sourceRequirements,
48-
requirementsContents.replace(editableLine, '')
48+
requirementsContents.replace(editableFlag, '')
4949
);
5050
}
5151

test.js

-5
Original file line numberDiff line numberDiff line change
@@ -727,13 +727,8 @@ test('poetry py3.6 can package flask with default options', t => {
727727
sls(['package']);
728728
const zipfiles = listZipFiles('.serverless/sls-py-req-test.zip');
729729
t.true(zipfiles.includes(`flask${sep}__init__.py`), 'flask is packaged');
730-
<<<<<<< HEAD
731730
t.true(zipfiles.includes(`bottle${sep}__init__.py`), 'bottle is packaged');
732731
t.true(zipfiles.includes(`boto3${sep}__init__.py`), 'boto3 is packaged');
733-
=======
734-
t.true(zipfiles.includes(`bottle.py`), 'bottle is packaged');
735-
t.false(zipfiles.includes(`boto3${sep}__init__.py`), 'boto3 is NOT packaged');
736-
>>>>>>> Fix wrongly expected file in test
737732
t.end();
738733
});
739734

0 commit comments

Comments
 (0)