fix(nextjs-component): do not allow same name to be specified across all lambdas(#1569)

Author: dphang

README.md

@@ -520,7 +520,7 @@ The fourth cache behaviour handles next API requests `api/*`.
 | tags | `object` | `undefined` | Tags to assign to a Lambda. If undefined, the component will not update any tags. If set to an empty object, it will remove all tags. |
 | timeout | `number\|object` | `10` | Same as above |
 | handler | `string` | `index.handler` | When assigned a value, overrides the default function handler to allow for configuration. Copies `handler.js` in route into the Lambda folders. Your handler MUST still call the `default-handler` afterwards or your function won't work with Next.JS |
-| name | `string\|object` | / | When assigned a string, both the default and api lambdas will assigned name of that value. When assigned to an object, values for the default and api lambdas can be separately defined |
+| name | `object` | / | Names for all lambdas can be explicitly defined |
 | build | `boolean\|object` | `true` | When true builds and deploys app, when false assume the app has been built and uses the `.next` `.serverless_nextjs` directories in `nextConfigDir` to deploy. If an object is passed `build` allows for overriding what script gets called and with what arguments. |
 | build.cmd | `string` | `node_modules/.bin/next` | Build command, you may pass a no-op command (e.g `true` or `:` in Unix-based systems) which will then skip the Next.js build |
 | build.args | `Array\|string` | `['build']` | Arguments to pass to the build |

packages/serverless-components/nextjs-component/__tests__/custom-inputs.test.ts

@@ -576,7 +576,6 @@ describe("Custom inputs", () => {
     inputName                                                     | expectedName
     ${undefined}                                                  | ${{ defaultName: undefined, apiName: undefined }}
     ${{}}                                                         | ${{ defaultName: undefined, apiName: undefined }}
-    ${"fooFunction"}                                              | ${{ defaultName: "fooFunction", apiName: "fooFunction" }}
     ${{ defaultLambda: "fooFunction" }}                           | ${{ defaultName: "fooFunction", apiName: undefined }}
     ${{ apiLambda: "fooFunction" }}                               | ${{ defaultName: undefined, apiName: "fooFunction" }}
     ${{ defaultLambda: "fooFunction", apiLambda: "barFunction" }} | ${{ defaultName: "fooFunction", apiName: "barFunction" }}
@@ -606,7 +605,8 @@ describe("Custom inputs", () => {
       const { defaultName, apiName } = expectedName;
 
       const expectedDefaultObject = {
-        code: path.join(fixturePath, DEFAULT_LAMBDA_CODE_DIR)
+        code: path.join(fixturePath, DEFAULT_LAMBDA_CODE_DIR),
+        name: undefined
       };
       if (defaultName) expectedDefaultObject.name = defaultName;
 
@@ -615,7 +615,8 @@ describe("Custom inputs", () => {
       );
 
       const expectedApiObject = {
-        code: path.join(fixturePath, API_LAMBDA_CODE_DIR)
+        code: path.join(fixturePath, API_LAMBDA_CODE_DIR),
+        name: undefined
       };
       if (apiName) expectedApiObject.name = apiName;
 

packages/serverless-components/nextjs-component/src/component.ts

@@ -467,6 +467,13 @@ class NextjsComponent extends Component {
       const inputValue = inputs[inputKey];
 
       if (typeof inputValue === "string" || typeof inputValue === "number") {
+        // For lambda name, we should not allow same name to be specified across all lambdas, as this can cause conflicts
+        if (inputKey === "name") {
+          throw new Error(
+            "Name cannot be specified across all Lambdas as it will cause conflicts."
+          );
+        }
+
         return inputValue;
       }