Skip to content

Default UTF-8 encoding should not include BOM #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nblumhardt opened this issue Jul 21, 2016 · 0 comments
Closed

Default UTF-8 encoding should not include BOM #9

nblumhardt opened this issue Jul 21, 2016 · 0 comments

Comments

@nblumhardt
Copy link
Member

https://github.com/serilog/serilog-sinks-file/blob/dev/src/Serilog.Sinks.File/Sinks/File/FileSink.cs#L59

The built-in Encoding.UTF8 object is problematic because it emits the byte order mark not otherwise required or expected in UTF-8 encoded files.

This should instead be a:

static readonly Encoding DefaultUtf8 = new UTF8Encoding(false);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant