Skip to content

Commit be730d4

Browse files
authored
Merge pull request #227 from nblumhardt/unpin-assembly-version
Unpin the assembly version
2 parents d599eb6 + 6f43751 commit be730d4

File tree

3 files changed

+1
-12
lines changed

3 files changed

+1
-12
lines changed

src/Serilog.Sinks.File/Properties/AssemblyInfo.cs

-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
using System.Reflection;
33
using System.Runtime.CompilerServices;
44

5-
[assembly: AssemblyVersion("2.0.0.0")]
6-
75
[assembly: CLSCompliant(true)]
86

97
[assembly: InternalsVisibleTo("Serilog.Sinks.File.Tests, PublicKey=" +

src/Serilog.Sinks.File/Serilog.Sinks.File.csproj

-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
<PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>
1717
<RepositoryUrl>https://github.com/serilog/serilog-sinks-file</RepositoryUrl>
1818
<RepositoryType>git</RepositoryType>
19-
<GenerateAssemblyVersionAttribute>false</GenerateAssemblyVersionAttribute>
2019
<RootNamespace>Serilog</RootNamespace>
2120
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
2221
<DisableImplicitFrameworkReferences Condition=" '$(TargetFramework)' == 'netstandard1.3' ">true</DisableImplicitFrameworkReferences>

test/Serilog.Sinks.File.Tests/RollingFileSinkTests.cs

+1-9
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
using System.IO;
44
using System.IO.Compression;
55
using System.Linq;
6-
using System.Reflection;
76
using Xunit;
87
using Serilog.Events;
98
using Serilog.Sinks.File.Tests.Support;
@@ -128,7 +127,7 @@ public void WhenRetentionCountAndTimeIsSetOldFilesAreDeletedByCount()
128127
Assert.True(System.IO.File.Exists(files[2]));
129128
});
130129
}
131-
130+
132131
[Fact]
133132
public void WhenRetentionCountAndArchivingHookIsSetOldFilesAreCopiedAndOriginalDeleted()
134133
{
@@ -261,13 +260,6 @@ public void IfTheLogFolderDoesNotExistItWillBeCreated()
261260
}
262261
}
263262

264-
[Fact]
265-
public void AssemblyVersionIsFixedAt200()
266-
{
267-
var assembly = typeof(FileLoggerConfigurationExtensions).GetTypeInfo().Assembly;
268-
Assert.Equal("2.0.0.0", assembly.GetName().Version.ToString(4));
269-
}
270-
271263
static void TestRollingEventSequence(params LogEvent[] events)
272264
{
273265
TestRollingEventSequence(

0 commit comments

Comments
 (0)