Check for directory existence before attempting access.

billrob · billrob · commit b15cb636fff4 · 2019-03-12T17:33:00.000-05:00
Stops exception from being thrown and tripping breakpoints when debugging application code.
diff --git a/src/Serilog.Sinks.File/Sinks/File/RollingFileSink.cs b/src/Serilog.Sinks.File/Sinks/File/RollingFileSink.cs
@@ -115,12 +115,11 @@ void OpenFile(DateTime now, int? minSequence = null)
             _nextCheckpoint = _roller.GetNextCheckpoint(now) ?? now.AddMinutes(30);
 
             var existingFiles = Enumerable.Empty<string>();
-            try
+            if (Directory.Exists(_roller.LogFileDirectory))
             {
                 existingFiles = Directory.GetFiles(_roller.LogFileDirectory, _roller.DirectorySearchPattern)
                                          .Select(Path.GetFileName);
             }
-            catch (DirectoryNotFoundException) { }
 
             var latestForThisCheckpoint = _roller
                 .SelectMatches(existingFiles)

Original file line number	Diff line number	Diff line change
`@@ -115,12 +115,11 @@ void OpenFile(DateTime now, int? minSequence = null)`
`115`	`115`	`_nextCheckpoint = _roller.GetNextCheckpoint(now) ?? now.AddMinutes(30);`
`116`	`116`
`117`	`117`	`var existingFiles = Enumerable.Empty<string>();`
`118`		`- try`
	`118`	`+ if (Directory.Exists(_roller.LogFileDirectory))`
`119`	`119`	`{`
`120`	`120`	`existingFiles = Directory.GetFiles(_roller.LogFileDirectory, _roller.DirectorySearchPattern)`
`121`	`121`	`.Select(Path.GetFileName);`
`122`	`122`	`}`
`123`		`- catch (DirectoryNotFoundException) { }`
`124`	`123`
`125`	`124`	`var latestForThisCheckpoint = _roller`
`126`	`125`	`.SelectMatches(existingFiles)`