Add note to README about the invariant culture change

And also mark all ReadFrom.Configuration() methods obsolete to encourage people to migrate to the new method that uses the invariant culture.

Note that when using `ReadFrom.Configuration(configuration)` without any additional parameter, the new method that takes a `ConfigurationContext` will be used automatically. This is exactly what happens in the sample project.

Author: 0xced

README.md

@@ -285,6 +285,8 @@ Some Serilog packages require a reference to a logger configuration object. The
 
 When the configuration specifies a discrete value for a parameter (such as a string literal), the package will attempt to convert that value to the target method's declared CLR type of the parameter. Additional explicit handling is provided for parsing strings to `Uri`, `TimeSpan`, `enum`, arrays and custom collections.
 
+Since version 3.5.0, conversion will use the invariant culture (`CultureInfo.InvariantCulture`) as long as the `ReadFrom.Configuration(IConfiguration configuration, ConfigurationContext context)` method is used. Obsolete methods use the current culture to preserve backward compatibility.
+
 ### Static member support
 
 Static member access can be used for passing to the configuration argument via [special](https://github.com/serilog/serilog-settings-configuration/blob/dev/test/Serilog.Settings.Configuration.Tests/StringArgumentValueTests.cs#L35) syntax:

src/Serilog.Settings.Configuration/ConfigurationLoggerConfigurationExtensions.cs

@@ -42,6 +42,7 @@ public static class ConfigurationLoggerConfigurationExtensions
     /// <param name="dependencyContext">The dependency context from which sink/enricher packages can be located. If not supplied, the platform
     /// default will be used.</param>
     /// <returns>An object allowing configuration to continue.</returns>
+    [Obsolete("Use ReadFrom.Configuration(IConfiguration configuration, ConfigurationContext context) instead.")]
     public static LoggerConfiguration Configuration(
         this LoggerSettingsConfiguration settingConfiguration,
         IConfiguration configuration,
@@ -66,6 +67,7 @@ public static LoggerConfiguration Configuration(
     /// <param name="dependencyContext">The dependency context from which sink/enricher packages can be located. If not supplied, the platform
     /// default will be used.</param>
     /// <returns>An object allowing configuration to continue.</returns>
+    [Obsolete("Use ReadFrom.Configuration(IConfiguration configuration, ConfigurationContext context) instead.")]
     public static LoggerConfiguration Configuration(
         this LoggerSettingsConfiguration settingConfiguration,
         IConfiguration configuration,
@@ -112,6 +114,7 @@ public static LoggerConfiguration ConfigurationSection(
     /// <param name="sectionName">A section name for section which contains a Serilog section.</param>
     /// <param name="configurationAssemblySource">Defines how the package identifies assemblies to scan for sinks and other types.</param>
     /// <returns>An object allowing configuration to continue.</returns>
+    [Obsolete("Use ReadFrom.Configuration(IConfiguration configuration, ConfigurationContext context) instead.")]
     public static LoggerConfiguration Configuration(
         this LoggerSettingsConfiguration settingConfiguration,
         IConfiguration configuration,
@@ -135,6 +138,7 @@ public static LoggerConfiguration Configuration(
     /// <param name="configuration">A configuration object which contains a Serilog section.</param>
     /// <param name="configurationAssemblySource">Defines how the package identifies assemblies to scan for sinks and other types.</param>
     /// <returns>An object allowing configuration to continue.</returns>
+    [Obsolete("Use ReadFrom.Configuration(IConfiguration configuration, ConfigurationContext context) instead.")]
     public static LoggerConfiguration Configuration(
         this LoggerSettingsConfiguration settingConfiguration,
         IConfiguration configuration,
@@ -171,6 +175,7 @@ public static LoggerConfiguration ConfigurationSection(
     /// <param name="sectionName">A section name for section which contains a Serilog section.</param>
     /// <param name="assemblies">A collection of assemblies that contains sinks and other types.</param>
     /// <returns>An object allowing configuration to continue.</returns>
+    [Obsolete("Use ReadFrom.Configuration(IConfiguration configuration, ConfigurationContext context) instead.")]
     public static LoggerConfiguration Configuration(
         this LoggerSettingsConfiguration settingConfiguration,
         IConfiguration configuration,
@@ -192,6 +197,7 @@ public static LoggerConfiguration Configuration(
     /// <param name="configuration">A configuration object which contains a Serilog section.</param>
     /// <param name="assemblies">A collection of assemblies that contains sinks and other types.</param>
     /// <returns>An object allowing configuration to continue.</returns>
+    [Obsolete("Use ReadFrom.Configuration(IConfiguration configuration, ConfigurationContext context) instead.")]
     public static LoggerConfiguration Configuration(
         this LoggerSettingsConfiguration settingConfiguration,
         IConfiguration configuration,

test/Serilog.Settings.Configuration.Tests/ConfigurationSettingsTests.cs

@@ -103,7 +103,7 @@ public void ConfigurationAssembliesFromDllScanning()
         var log = new LoggerConfiguration()
             .ReadFrom.Configuration(
                 configuration: config,
-                configurationAssemblySource: ConfigurationAssemblySource.AlwaysScanDllFiles)
+                context: new ConfigurationContext(ConfigurationAssemblySource.AlwaysScanDllFiles))
             .CreateLogger();
 
         DummyConsoleSink.Emitted.Clear();

test/Serilog.Settings.Configuration.Tests/LoggerConfigurationExtensionsTests.cs

@@ -96,7 +96,7 @@ public void ReadFromConfigurationDoesNotThrowWhenTryingToCallConfigurationMethod
             .Build();
 
         _ = new LoggerConfiguration()
-               .ReadFrom.Configuration(config, "NotSerilog")
+               .ReadFrom.Configuration(config, new ConfigurationContext { SectionName = "NotSerilog" })
                .CreateLogger();
 
     }