Merge pull request #365 from 0xced/nullable-reference-types-fixes

Fix some nullable reference type issues

Author: nblumhardt

src/Serilog.Settings.Configuration/Settings/Configuration/Assemblies/AssemblyFinder.cs

@@ -7,7 +7,7 @@ abstract class AssemblyFinder
 {
     public abstract IReadOnlyList<AssemblyName> FindAssembliesContainingName(string nameToFind);
 
-    protected static bool IsCaseInsensitiveMatch(string text, string textToFind)
+    protected static bool IsCaseInsensitiveMatch(string? text, string textToFind)
     {
         return text != null && text.ToLowerInvariant().Contains(textToFind.ToLowerInvariant());
     }

src/Serilog.Settings.Configuration/Settings/Configuration/ConfigurationReader.cs

@@ -413,7 +413,7 @@ static bool HasImplicitValueWhenNotSpecified(ParameterInfo paramInfo)
            || paramInfo.ParameterType == typeof(IConfiguration);
     }
 
-    object GetImplicitValueForNotSpecifiedKey(ParameterInfo parameter, MethodInfo methodToInvoke)
+    object? GetImplicitValueForNotSpecifiedKey(ParameterInfo parameter, MethodInfo methodToInvoke)
     {
         if (!HasImplicitValueWhenNotSpecified(parameter))
         {

src/Serilog.Settings.Configuration/Settings/Configuration/StringArgumentValue.cs

@@ -173,7 +173,7 @@ public StringArgumentValue(string providedValue)
         return type;
     }
 
-    internal static bool TryParseStaticMemberAccessor(string input, [NotNullWhen(true)] out string? accessorTypeName, [NotNullWhen(true)] out string? memberName)
+    internal static bool TryParseStaticMemberAccessor(string? input, [NotNullWhen(true)] out string? accessorTypeName, [NotNullWhen(true)] out string? memberName)
     {
         if (input == null)
         {

test/Serilog.Settings.Configuration.Tests/ObjectArgumentValueTests.cs

@@ -29,7 +29,7 @@ public void ShouldBindToConstructorArguments(string caseSection, Type targetType
         var testSection = _config.GetSection(caseSection);
 
         Assert.True(ObjectArgumentValue.TryBuildCtorExpression(testSection, targetType, new(), out var ctorExpression));
-        Assert.Equal(expectedExpression, ctorExpression?.ToString());
+        Assert.Equal(expectedExpression, ctorExpression.ToString());
     }
 
     class A

test/Serilog.Settings.Configuration.Tests/StringArgumentValueTests.cs

@@ -53,7 +53,7 @@ public void StringValuesConvertToDefaultInstancesIfTargetIsAbstractClass()
     // a full-qualified type name should not be considered a static member accessor
     [InlineData("My.NameSpace.Class, MyAssembly, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089",
        null, null)]
-    public void TryParseStaticMemberAccessorReturnsExpectedResults(string input, string expectedAccessorType, string expectedPropertyName)
+    public void TryParseStaticMemberAccessorReturnsExpectedResults(string input, string? expectedAccessorType, string expectedPropertyName)
     {
         var actual = StringArgumentValue.TryParseStaticMemberAccessor(input,
             out var actualAccessorType,