Skip to content

Make function ConvertLevel public availabe so we can use it in our code #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xrkolovos opened this issue Jul 6, 2017 · 6 comments · Fixed by #141
Closed

Make function ConvertLevel public availabe so we can use it in our code #81

xrkolovos opened this issue Jul 6, 2017 · 6 comments · Fixed by #141
Labels

Comments

@xrkolovos
Copy link

Make function ConvertLevel public availabe so we can use it in our code

@nblumhardt
Copy link
Member

Thanks for the note @xrkolovos - what scenario would you use it in?

Regards,
Nick

@nblumhardt
Copy link
Member

Closing for now as I think we might prefer to avoid adding more surface area to this library, but keen to collect any scenario info/feedback on this so feel free to add further comments here.

@xrkolovos
Copy link
Author

I wanted to use it in my code, i just copied the function. I thing is usefull and it is kind in the spirit of this package.
It's your call.

@sanderd
Copy link

sanderd commented Apr 25, 2018

Needed it, copied it, but would also like it to be exposed instead.

Use-case:
Company nuget library that depends on a serilog sink, but its surface area is .NET Core logging.

@nblumhardt
Copy link
Member

Perhaps we should take another look at this. Thanks for the feedback :-)

@nblumhardt nblumhardt reopened this Apr 25, 2018
@neman
Copy link
Contributor

neman commented Apr 26, 2018

I saw this issue just now. I also copied the same method for internal logging nuget package (1.5 years ago).
I used this same method, didn't even think about opening an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants