Skip to content

Small typo with properties example in documentation #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghost opened this issue Mar 5, 2024 · 1 comment · Fixed by #364
Closed

Small typo with properties example in documentation #363

ghost opened this issue Mar 5, 2024 · 1 comment · Fixed by #364
Labels
bug

Comments

@ghost
Copy link

ghost commented Mar 5, 2024 •
edited by ghost
Loading

Believe there is a bug in the example in https://github.com/serilog/serilog-aspnetcore#pushing-properties-to-the-iloggert. It should be LogContext.PushProperty rather than logger.PushProperty. Alternatively or additionally it can also point to https://github.com/serilog/serilog/wiki/Enrichment#the-logcontext for more information.

However it would be be a nice to have ILogger.PushProperty which then forwards to LogContext.PushProperty.
@ghost ghost added the bug label Mar 5, 2024
@ghost ghost closed this as completed Mar 5, 2024
@ghost ghost reopened this Mar 5, 2024
@ghost ghost mentioned this issue Mar 5, 2024
Merged
@ghost ghost changed the title Small typo with PushProperty example in documentation Small typo with properties example in documentation Mar 5, 2024
@ghost
Copy link
Author

ghost commented Mar 5, 2024

PR #364

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix properties example to use LogContext
0 participants