Skip to content
This repository was archived by the owner on Jun 1, 2024. It is now read-only.

Commit 5c6985c

Browse files
nenadvicenticNenad Vicentic
and
Nenad Vicentic
authored
#498 Disable PublicSign to fix strong-name signature verification issue of assemblies from public NuGet package: (#504)
> Could not load file or assembly 'Serilog.Formatting.Elasticsearch' or one of its dependencies. Strong name signature could not be verified. The assembly may have been tampered with, or it was delay signed but not fully signed with the correct private key. (Exception from HRESULT: 0x80131045)" Co-authored-by: Nenad Vicentic <[email protected]>
1 parent 9a75528 commit 5c6985c

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

src/Serilog.Formatting.Elasticsearch/Serilog.Formatting.Elasticsearch.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<AssemblyName>Serilog.Formatting.Elasticsearch</AssemblyName>
1414
<AssemblyOriginatorKeyFile>../../assets/Serilog.snk</AssemblyOriginatorKeyFile>
1515
<SignAssembly>true</SignAssembly>
16-
<PublicSign Condition=" '$(OS)' != 'Windows_NT' ">true</PublicSign>
16+
<PublicSign>false</PublicSign>
1717
<PackageId>Serilog.Formatting.Elasticsearch</PackageId>
1818
<PackageTags>serilog;elasticsearch;logging;event;formatting</PackageTags>
1919
<PackageReleaseNotes>https://github.com/serilog-contrib/serilog-sinks-elasticsearch/blob/master/CHANGES.md</PackageReleaseNotes>

src/Serilog.Sinks.Elasticsearch/Serilog.Sinks.Elasticsearch.csproj

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<AssemblyName>Serilog.Sinks.Elasticsearch</AssemblyName>
1414
<AssemblyOriginatorKeyFile>../../assets/Serilog.snk</AssemblyOriginatorKeyFile>
1515
<SignAssembly>true</SignAssembly>
16-
<PublicSign Condition=" '$(OS)' != 'Windows_NT' ">true</PublicSign>
16+
<PublicSign>false</PublicSign>
1717
<PackageId>Serilog.Sinks.Elasticsearch</PackageId>
1818
<PackageTags>serilog;elasticsearch;logging;event;collector</PackageTags>
1919
<PackageReleaseNotes>https://github.com/serilog-contrib/serilog-sinks-elasticsearch/blob/master/CHANGES.md</PackageReleaseNotes>
@@ -42,10 +42,6 @@
4242
<PackageReference Include="System.Diagnostics.DiagnosticSource" Version="6.0.0" />
4343
</ItemGroup>
4444

45-
<ItemGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' ">
46-
<PackageReference Include="Microsoft.CSharp" Version="4.7.0" />
47-
</ItemGroup>
48-
4945
<ItemGroup>
5046
<AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleTo">
5147
<_Parameter1>Serilog.Sinks.Elasticsearch.Tests, PublicKey=0024000004800000940000000602000000240000525341310004000001000100fb8d13fd344a1c6fe0fe83ef33c1080bf30690765bc6eb0df26ebfdf8f21670c64265b30db09f73a0dea5b3db4c9d18dbf6d5a25af5ce9016f281014d79dc3b4201ac646c451830fc7e61a2dfd633d34c39f87b81894191652df5ac63cc40c77f3542f702bda692e6e8a9158353df189007a49da0f3cfd55eb250066b19485ec</_Parameter1>

0 commit comments

Comments
 (0)