Skip to content

[v3] typescript definition is missing #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sijad opened this issue Aug 6, 2019 · 4 comments
Closed

[v3] typescript definition is missing #37

sijad opened this issue Aug 6, 2019 · 4 comments

Comments

@sijad
Copy link

sijad commented Aug 6, 2019

No description provided.

@sergeyshpadyrev
Copy link
Owner

Yes, it's known issue. I'm not very familiar with typescript but I gonna try to create types for it

@christianchown
Copy link
Collaborator

Hi Sergey

I've just started playing with v3; I have a set of types that I can use to open a PR with. It might be worth following this approach though:

testing-library/react-testing-library#437
https://blog.johnnyreilly.com/2019/08/symbiotic-definitely-typed.html
https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html

(tl;dr add a dev dependency in package.json to @types/react-native-easy-router and let the community maintain the types at DefinitelyTyped)

@sergeyshpadyrev
Copy link
Owner

@christianchown I'm going to return to work on v3 after a long gap. Most important goal now is to add typescript support. I don't like DefinitelyTyped solution very much because react-native-easy-router is not popular enough to have a community that can support types. Anyway it'll be done by me or you so it's better to do it in repo.

@sergeyshpadyrev
Copy link
Owner

So it's done and released in v3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants