Merge pull request #1173 from iex-rs/fix-big-endian

Oops, fix skip_to_escape on BE architectures

Author: dtolnay

src/read.rs

@@ -453,22 +453,17 @@ impl<'a> SliceRead<'a> {
         const ONE_BYTES: Chunk = Chunk::MAX / 255; // 0x0101...01
 
         for chunk in rest.chunks_exact(STEP) {
-            let chars = Chunk::from_ne_bytes(chunk.try_into().unwrap());
+            let chars = Chunk::from_le_bytes(chunk.try_into().unwrap());
             let contains_ctrl = chars.wrapping_sub(ONE_BYTES * 0x20) & !chars;
             let chars_quote = chars ^ (ONE_BYTES * Chunk::from(b'"'));
             let contains_quote = chars_quote.wrapping_sub(ONE_BYTES) & !chars_quote;
             let chars_backslash = chars ^ (ONE_BYTES * Chunk::from(b'\\'));
             let contains_backslash = chars_backslash.wrapping_sub(ONE_BYTES) & !chars_backslash;
             let masked = (contains_ctrl | contains_quote | contains_backslash) & (ONE_BYTES << 7);
             if masked != 0 {
-                let addresswise_first_bit = if cfg!(target_endian = "little") {
-                    masked.trailing_zeros()
-                } else {
-                    masked.leading_zeros()
-                };
                 // SAFETY: chunk is in-bounds for slice
                 self.index = unsafe { chunk.as_ptr().offset_from(self.slice.as_ptr()) } as usize
-                    + addresswise_first_bit as usize / 8;
+                    + masked.trailing_zeros() as usize / 8;
                 return;
             }
         }

tests/test.rs

@@ -2504,7 +2504,7 @@ fn test_control_character_search() {
     for n in 0..16 {
         for m in 0..16 {
             test_parse_err::<String>(&[(
-                &format!("\"{}\n{}\"", ".".repeat(n), ".".repeat(m)),
+                &format!("\"{}\n{}\"", " ".repeat(n), " ".repeat(m)),
                 "control character (\\u0000-\\u001F) found while parsing a string at line 2 column 0",
             )]);
         }