Skip to content

Commit ef4c26e

Browse files
committed
lint
1 parent 6c59d82 commit ef4c26e

14 files changed

+87
-69
lines changed

modules/kms-keyring-browser/src/kms_keyring_browser.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,9 @@ const getKmsClient = getClient(KMS, {
3030
})
3131
const cacheKmsClients = cacheClients(getKmsClient)
3232

33-
export type KmsKeyringWebCryptoInput = Partial<KmsKeyringInput<AwsEsdkKMSInterface>>
33+
export type KmsKeyringWebCryptoInput = Partial<
34+
KmsKeyringInput<AwsEsdkKMSInterface>
35+
>
3436
export type KMSWebCryptoConstructible = KMSConstructible<
3537
KMS,
3638
KMS.ClientConfiguration

modules/kms-keyring-browser/src/kms_mrk_discovery_multi_keyring_browser.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
// Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
22
// SPDX-License-Identifier: Apache-2.0
33

4-
import { getAwsKmsMrkAwareDiscoveryMultiKeyringBuilder, AwsEsdkKMSInterface } from '@aws-crypto/kms-keyring'
4+
import {
5+
getAwsKmsMrkAwareDiscoveryMultiKeyringBuilder,
6+
AwsEsdkKMSInterface,
7+
} from '@aws-crypto/kms-keyring'
58
import {
69
MultiKeyringWebCrypto,
710
WebCryptoAlgorithmSuite,
@@ -10,7 +13,10 @@ import { getKmsClient } from '.'
1013
import { AwsKmsMrkAwareSymmetricDiscoveryKeyringBrowser } from './kms_mrk_discovery_keyring_browser'
1114

1215
export const buildAwsKmsMrkAwareDiscoveryMultiKeyringBrowser =
13-
getAwsKmsMrkAwareDiscoveryMultiKeyringBuilder<WebCryptoAlgorithmSuite, AwsEsdkKMSInterface>(
16+
getAwsKmsMrkAwareDiscoveryMultiKeyringBuilder<
17+
WebCryptoAlgorithmSuite,
18+
AwsEsdkKMSInterface
19+
>(
1420
AwsKmsMrkAwareSymmetricDiscoveryKeyringBrowser,
1521
MultiKeyringWebCrypto,
1622
getKmsClient
Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
// Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
22
// SPDX-License-Identifier: Apache-2.0
33

4-
import { getAwsKmsMrkAwareStrictMultiKeyringBuilder, AwsEsdkKMSInterface } from '@aws-crypto/kms-keyring'
4+
import {
5+
getAwsKmsMrkAwareStrictMultiKeyringBuilder,
6+
AwsEsdkKMSInterface,
7+
} from '@aws-crypto/kms-keyring'
58
import {
69
MultiKeyringWebCrypto,
710
WebCryptoAlgorithmSuite,
@@ -10,8 +13,7 @@ import { getKmsClient } from '.'
1013
import { AwsKmsMrkAwareSymmetricKeyringBrowser } from './kms_mrk_keyring_browser'
1114

1215
export const buildAwsKmsMrkAwareStrictMultiKeyringBrowser =
13-
getAwsKmsMrkAwareStrictMultiKeyringBuilder<WebCryptoAlgorithmSuite, AwsEsdkKMSInterface>(
14-
AwsKmsMrkAwareSymmetricKeyringBrowser,
15-
MultiKeyringWebCrypto,
16-
getKmsClient
17-
)
16+
getAwsKmsMrkAwareStrictMultiKeyringBuilder<
17+
WebCryptoAlgorithmSuite,
18+
AwsEsdkKMSInterface
19+
>(AwsKmsMrkAwareSymmetricKeyringBrowser, MultiKeyringWebCrypto, getKmsClient)

modules/kms-keyring-browser/test/kms_keyring_browser.test.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,6 @@ describe('KmsKeyringBrowser can encrypt/decrypt with AWS SDK v2 client', () => {
9191
})
9292
})
9393

94-
9594
describe('KmsKeyringBrowser can encrypt/decrypt with AWS SDK v3 client', () => {
9695
const generatorKeyId =
9796
'arn:aws:kms:us-west-2:658956600833:alias/EncryptDecrypt'
@@ -130,4 +129,4 @@ describe('KmsKeyringBrowser can encrypt/decrypt with AWS SDK v3 client', () => {
130129
// The UnencryptedDataKey should be zeroed, because the cryptoKey has been set
131130
expect(() => test.getUnencryptedDataKey()).to.throw()
132131
})
133-
})
132+
})

modules/kms-keyring-browser/test/kms_mrk_keyring_browser.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,4 +175,4 @@ describe('AwsKmsMrkAwareSymmetricKeyringBrowser can encrypt/decrypt with AWS SDK
175175
// The UnencryptedDataKey should be zeroed, because the cryptoKey has been set
176176
expect(() => test.getUnencryptedDataKey()).to.throw()
177177
})
178-
})
178+
})

modules/kms-keyring-node/src/kms_keyring_node.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {
1010
limitRegions,
1111
excludeRegions,
1212
cacheClients,
13-
AwsEsdkKMSInterface
13+
AwsEsdkKMSInterface,
1414
} from '@aws-crypto/kms-keyring'
1515
import {
1616
immutableClass,
@@ -32,9 +32,10 @@ export type KMSNodeConstructible = KMSConstructible<
3232
>
3333
export type KmsNodeClientSupplier = KmsClientSupplier<AwsEsdkKMSInterface>
3434

35-
export class KmsKeyringNode extends KmsKeyringClass<NodeAlgorithmSuite, AwsEsdkKMSInterface>(
36-
KeyringNode as Newable<KeyringNode>
37-
) {
35+
export class KmsKeyringNode extends KmsKeyringClass<
36+
NodeAlgorithmSuite,
37+
AwsEsdkKMSInterface
38+
>(KeyringNode as Newable<KeyringNode>) {
3839
constructor({
3940
clientProvider = cacheKmsClients,
4041
keyIds,

modules/kms-keyring-node/src/kms_mrk_discovery_keyring_node.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ export type AwsKmsMrkAwareSymmetricDiscoveryKeyringNodeInput =
1616
AwsKmsMrkAwareSymmetricDiscoveryKeyringInput<AwsEsdkKMSInterface>
1717

1818
export const AwsKmsMrkAwareSymmetricDiscoveryKeyringNode =
19-
AwsKmsMrkAwareSymmetricDiscoveryKeyringClass<NodeAlgorithmSuite, AwsEsdkKMSInterface>(
20-
KeyringNode as Newable<KeyringNode>
21-
)
19+
AwsKmsMrkAwareSymmetricDiscoveryKeyringClass<
20+
NodeAlgorithmSuite,
21+
AwsEsdkKMSInterface
22+
>(KeyringNode as Newable<KeyringNode>)

modules/kms-keyring-node/src/kms_mrk_discovery_multi_keyring_node.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,7 @@ export interface AwsKmsMrkAwareDiscoveryMultiKeyringNodeInput {
2424
}
2525

2626
export const buildAwsKmsMrkAwareDiscoveryMultiKeyringNode =
27-
getAwsKmsMrkAwareDiscoveryMultiKeyringBuilder<NodeAlgorithmSuite, AwsEsdkKMSInterface>(
28-
AwsKmsMrkAwareSymmetricDiscoveryKeyringNode,
29-
MultiKeyringNode,
30-
getKmsClient
31-
)
27+
getAwsKmsMrkAwareDiscoveryMultiKeyringBuilder<
28+
NodeAlgorithmSuite,
29+
AwsEsdkKMSInterface
30+
>(AwsKmsMrkAwareSymmetricDiscoveryKeyringNode, MultiKeyringNode, getKmsClient)

modules/kms-keyring-node/src/kms_mrk_strict_multi_keyring_node.ts

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
// Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
22
// SPDX-License-Identifier: Apache-2.0
33

4-
import { getAwsKmsMrkAwareStrictMultiKeyringBuilder, AwsEsdkKMSInterface } from '@aws-crypto/kms-keyring'
4+
import {
5+
getAwsKmsMrkAwareStrictMultiKeyringBuilder,
6+
AwsEsdkKMSInterface,
7+
} from '@aws-crypto/kms-keyring'
58
import { KmsClientSupplier } from '@aws-crypto/kms-keyring'
69
import {
710
MultiKeyringNode,
@@ -18,8 +21,7 @@ export interface AwsKmsMrkAwareStrictMultiKeyringNodeInput {
1821
}
1922

2023
export const buildAwsKmsMrkAwareStrictMultiKeyringNode =
21-
getAwsKmsMrkAwareStrictMultiKeyringBuilder<NodeAlgorithmSuite, AwsEsdkKMSInterface>(
22-
AwsKmsMrkAwareSymmetricKeyringNode,
23-
MultiKeyringNode,
24-
getKmsClient
25-
)
24+
getAwsKmsMrkAwareStrictMultiKeyringBuilder<
25+
NodeAlgorithmSuite,
26+
AwsEsdkKMSInterface
27+
>(AwsKmsMrkAwareSymmetricKeyringNode, MultiKeyringNode, getKmsClient)

modules/kms-keyring-node/test/kms_keyring_node.test.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,9 @@ describe('KmsKeyringNode can encrypt/decrypt with AWS SDK v2 client', () => {
4646
const keyArn =
4747
'arn:aws:kms:us-west-2:658956600833:key/b3537ef1-d8dc-4780-9f5a-55776cbb2f7f'
4848
const keyIds = [keyArn]
49-
49+
5050
const clientProvider = getClient(V2KMS)
51-
51+
5252
const keyring = new KmsKeyringNode({ clientProvider, generatorKeyId, keyIds })
5353
let encryptedDataKey: EncryptedDataKey
5454
let udk: Uint8Array
@@ -115,5 +115,3 @@ describe('KmsKeyringNode can encrypt/decrypt with AWS SDK v3 client', () => {
115115
expect(unwrapDataKey(test.getUnencryptedDataKey())).to.deep.equal(udk)
116116
})
117117
})
118-
119-

modules/kms-keyring-node/test/kms_mrk_discovery_keyring_node.test.ts

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -126,12 +126,11 @@ describe('AwsKmsMrkAwareSymmetricDiscoveryKeyringNode can encrypt/decrypt with A
126126
})
127127

128128
it('can decrypt an EncryptedDataKey', async () => {
129-
const { CiphertextBlob } = await client
130-
.generateDataKey({
131-
KeyId: keyId,
132-
NumberOfBytes: suite.keyLengthBytes,
133-
EncryptionContext: encryptionContext,
134-
})
129+
const { CiphertextBlob } = await client.generateDataKey({
130+
KeyId: keyId,
131+
NumberOfBytes: suite.keyLengthBytes,
132+
EncryptionContext: encryptionContext,
133+
})
135134
console.log(CiphertextBlob)
136135
needs(CiphertextBlob instanceof Uint8Array, 'never')
137136
const edk = new EncryptedDataKey({
@@ -147,4 +146,4 @@ describe('AwsKmsMrkAwareSymmetricDiscoveryKeyringNode can encrypt/decrypt with A
147146
const decryptTest = await keyring.onDecrypt(material, [edk])
148147
expect(decryptTest.hasValidKey()).to.equal(true)
149148
})
150-
})
149+
})

modules/kms-keyring/src/kms_mrk_discovery_keyring.ts

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -140,13 +140,12 @@ export function AwsKmsMrkAwareSymmetricDiscoveryKeyringClass<
140140
* then the keyring would filter out all EDKs
141141
* because the region does not match.
142142
*/
143-
this.clientRegion = clientRegion()
144-
.then((region: string) => {
145-
/* Postcondition: Resolve the AWS SDK V3 region promise and update clientRegion. */
146-
readOnlyProperty(this, 'clientRegion', region)
147-
/* Postcondition: Resolve the promise with the value set. */
148-
return region
149-
})
143+
this.clientRegion = clientRegion().then((region: string) => {
144+
/* Postcondition: Resolve the AWS SDK V3 region promise and update clientRegion. */
145+
readOnlyProperty(this, 'clientRegion', region)
146+
/* Postcondition: Resolve the promise with the value set. */
147+
return region
148+
})
150149
} else {
151150
readOnlyProperty(this, 'clientRegion', clientRegion)
152151
}
@@ -189,14 +188,15 @@ export function AwsKmsMrkAwareSymmetricDiscoveryKeyringClass<
189188

190189
// See the constructor, this is to support both AWS SDK v2 and v3.
191190
needs(
192-
typeof this.clientRegion === 'string'
193-
/* Precondition: AWS SDK V3 region promise MUST have resolved to a string.
194-
* In the constructor the region promise resolves
195-
* to the same value that is then set.
196-
*/
197-
// @ts-ignore
198-
|| typeof (await this.clientRegion) == 'string'
199-
, 'clientRegion MUST be a string.')
191+
typeof this.clientRegion === 'string' ||
192+
/* Precondition: AWS SDK V3 region promise MUST have resolved to a string.
193+
* In the constructor the region promise resolves
194+
* to the same value that is then set.
195+
*/
196+
// @ts-ignore
197+
typeof (await this.clientRegion) == 'string',
198+
'clientRegion MUST be a string.'
199+
)
200200

201201
const { client, grantTokens, clientRegion } = this
202202

modules/kms-keyring/test/kms_mrk_discovery_keyring.constructor.test.ts

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -102,13 +102,16 @@ describe('AwsKmsMrkAwareSymmetricDiscoveryKeyring: constructor', () => {
102102
}
103103
})
104104

105-
106105
it('Postcondition: Store the AWS SDK V3 region promise as the clientRegion.', async () => {
107106
let regionCalled = false
108-
const client: any = { config: { region: async () => {
109-
regionCalled = true
110-
return 'us-west-2'
111-
} } }
107+
const client: any = {
108+
config: {
109+
region: async () => {
110+
regionCalled = true
111+
return 'us-west-2'
112+
},
113+
},
114+
}
112115

113116
class TestAwsKmsMrkAwareSymmetricDiscoveryKeyring extends AwsKmsMrkAwareSymmetricDiscoveryKeyringClass(
114117
Keyring as Newable<Keyring<NodeAlgorithmSuite>>
@@ -120,7 +123,10 @@ describe('AwsKmsMrkAwareSymmetricDiscoveryKeyring: constructor', () => {
120123
expect(regionCalled).to.equal(true)
121124
expect(test.clientRegion).to.not.equal(client.config.region)
122125
// @ts-ignore This is to check that the value is a promise
123-
expect(typeof test.clientRegion === 'object' && typeof test.clientRegion.then === 'function').to.equal(true)
126+
expect(
127+
typeof test.clientRegion === 'object' &&
128+
typeof test.clientRegion.then === 'function'
129+
).to.equal(true)
124130
})
125131

126132
it('Postcondition: Resolve the AWS SDK V3 region promise and update clientRegion.', async () => {
@@ -136,7 +142,9 @@ describe('AwsKmsMrkAwareSymmetricDiscoveryKeyring: constructor', () => {
136142
})
137143
await test.clientRegion
138144
expect(test.clientRegion).to.equal(region)
139-
expect(Object.getOwnPropertyDescriptor(test, 'clientRegion')?.writable).to.equal(false)
145+
expect(
146+
Object.getOwnPropertyDescriptor(test, 'clientRegion')?.writable
147+
).to.equal(false)
140148
})
141149

142150
it('Postcondition: Resolve the promise with the value set.', async () => {
@@ -150,7 +158,7 @@ describe('AwsKmsMrkAwareSymmetricDiscoveryKeyring: constructor', () => {
150158
const test = new TestAwsKmsMrkAwareSymmetricDiscoveryKeyring({
151159
client,
152160
})
153-
161+
154162
await expect(test.clientRegion).to.eventually.equal(region)
155163
})
156164
})

modules/kms-keyring/test/kms_mrk_discovery_keyring.ondecrypt.test.ts

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -817,11 +817,12 @@ describe('AwsKmsMrkAwareSymmetricDiscoveryKeyring: _onDecrypt', () => {
817817
client,
818818
})
819819

820-
await expect((async () => {
821-
const material: any = { hasValidKey: () => false}
822-
823-
await test._onDecrypt(material, [])
820+
await expect(
821+
(async () => {
822+
const material: any = { hasValidKey: () => false }
824823

825-
})()).to.eventually.rejectedWith('clientRegion MUST be a string.')
824+
await test._onDecrypt(material, [])
825+
})()
826+
).to.eventually.rejectedWith('clientRegion MUST be a string.')
826827
})
827828
})

0 commit comments

Comments
 (0)