Skip to content

Commit 13519fd

Browse files
author
Cosmin Cojocar
committed
Update the tls configuration generate to handle also the NSS alternative names
Regenerate the configuration of TLS rule. Signed-off-by: Cosmin Cojocar <[email protected]>
1 parent e351067 commit 13519fd

File tree

3 files changed

+10
-0
lines changed

3 files changed

+10
-0
lines changed

cmd/tlsconfig/tlsconfig.go

+3
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,9 @@ func getGoCipherConfig(name string, sstls ServerSideTLSJson) (goCipherConfigurat
9797
}
9898
if len(cipherSuite.IANAName) > 0 {
9999
cipherConf.Ciphers = append(cipherConf.Ciphers, cipherSuite.IANAName)
100+
if len(cipherSuite.NSSName) > 0 && cipherSuite.NSSName != cipherSuite.IANAName {
101+
cipherConf.Ciphers = append(cipherConf.Ciphers, cipherSuite.NSSName)
102+
}
100103
}
101104
}
102105

go.sum

+3
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ github.com/gookit/color v1.2.5 h1:s1gzb/fg3HhkSLKyWVUsZcVBUo+R1TwEYTmmxH8gGFg=
2323
github.com/gookit/color v1.2.5/go.mod h1:AhIE+pS6D4Ql0SQWbBeXPHw7gY0/sjHoA4s/n1KB7xg=
2424
github.com/gookit/color v1.2.7 h1:4qePMNWZhrmbfYJDix+J4V2l0iVW+6jQGjicELlN14E=
2525
github.com/gookit/color v1.2.7/go.mod h1:AhIE+pS6D4Ql0SQWbBeXPHw7gY0/sjHoA4s/n1KB7xg=
26+
github.com/gookit/color v1.2.8 h1:9wExr3qoZN7h81JecfXkynnlAWLPlvDmVMqLw9Sr6Cw=
2627
github.com/gookit/color v1.2.8/go.mod h1:AhIE+pS6D4Ql0SQWbBeXPHw7gY0/sjHoA4s/n1KB7xg=
2728
github.com/hpcloud/tail v1.0.0 h1:nfCOvKYfkgYP8hkirhJocXT2+zOD8yUNjXaWfTlyFKI=
2829
github.com/hpcloud/tail v1.0.0/go.mod h1:ab1qPbhIpdTxEkNHXyeSf5vhxWSCs/tWer42PpOxQnU=
@@ -65,6 +66,7 @@ golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550/go.mod h1:yigFU9vqHzYiE8U
6566
golang.org/x/crypto v0.0.0-20200622213623-75b288015ac9/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto=
6667
golang.org/x/mod v0.2.0 h1:KU7oHjnv3XNWfa5COkzUifxZmxp1TyI7ImMXqFxLwvQ=
6768
golang.org/x/mod v0.2.0/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA=
69+
golang.org/x/mod v0.3.0 h1:RM4zey1++hCTbCVQfnWeKs9/IEsaBLA8vTkd0WVtmH4=
6870
golang.org/x/mod v0.3.0/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA=
6971
golang.org/x/net v0.0.0-20180906233101-161cd47e91fd/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=
7072
golang.org/x/net v0.0.0-20190404232315-eb5bcb51f2a3/go.mod h1:t9HGtf8HONx5eT2rtn7q6eTqICYqUVnKs3thJo3Qplg=
@@ -109,6 +111,7 @@ golang.org/x/xerrors v0.0.0-20191011141410-1b5146add898 h1:/atklqdjdhuosWIl6AIbO
109111
golang.org/x/xerrors v0.0.0-20191011141410-1b5146add898/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
110112
golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543 h1:E7g+9GITq07hpfrRu66IVDexMakfv52eLZ2CXBWiKr4=
111113
golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
114+
golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1 h1:go1bK/D/BFZV2I8cIQd1NKEZ+0owSTG1fDTci4IqFcE=
112115
golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
113116
google.golang.org/protobuf v0.0.0-20200109180630-ec00e32a8dfd/go.mod h1:DFci5gLYBciE7Vtevhsrf46CRTquxDuWsQurQQe4oz8=
114117
google.golang.org/protobuf v0.0.0-20200221191635-4d8936d0db64/go.mod h1:kwYJMbMJ01Woi6D6+Kah6886xMZcty6N08ah7+eCXa0=

rules/tls_config.go

+4
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,9 @@ func NewIntermediateTLSCheck(id string, conf gosec.Config) (gosec.Rule, []ast.No
3939
"TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384",
4040
"TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384",
4141
"TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305",
42+
"TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256",
4243
"TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305",
44+
"TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256",
4345
"TLS_DHE_RSA_WITH_AES_128_GCM_SHA256",
4446
"TLS_DHE_RSA_WITH_AES_256_GCM_SHA384",
4547
},
@@ -63,7 +65,9 @@ func NewOldTLSCheck(id string, conf gosec.Config) (gosec.Rule, []ast.Node) {
6365
"TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384",
6466
"TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384",
6567
"TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305",
68+
"TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256",
6669
"TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305",
70+
"TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256",
6771
"TLS_DHE_RSA_WITH_AES_128_GCM_SHA256",
6872
"TLS_DHE_RSA_WITH_AES_256_GCM_SHA384",
6973
"TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256",

0 commit comments

Comments
 (0)