-
Notifications
You must be signed in to change notification settings - Fork 137
PHPUnit_Extensions_Database_DataSet_CompositeDataSet() requires an array argument. #184
Comments
Are you using DbUnit 1.3.1? I believe this issue was addressed in that release. |
Commit 89139eaa168e0cdfd9c2ee4bae2e7d5fb5e58c76 makes that constructor parameter optional, and indeed it was released last week. Thanks! (but the documentation is still lacking) |
Can you provide specifics on why the documentation is lacking? There's an example of <?php
class CompositeTest extends PHPUnit_Extensions_Database_TestCase
{
public function getDataSet()
{
$ds1 = $this->createFlatXmlDataSet('fixture1.xml');
$ds2 = $this->createFlatXmlDataSet('fixture2.xml');
$compositeDs = new PHPUnit_Extensions_Database_DataSet_CompositeDataSet();
$compositeDs->addDataSet($ds1);
$compositeDs->addDataSet($ds2);
return $compositeDs;
}
}
?> |
Lacking the description of the (optional) parameter from the constructor. (sorry for my tone, I guess I was a bit too angry, I should have calmed down and posted a more helpful issue) |
No worries, just trying to get as much information as I can while the apparently painful memory is still fresh. ;) We'll try to get this addressed. Thanks for the issue report! |
Dear contributor, thanks to the hard work by @belanur, @starikovm, @trueromio, and others, the changes outlined in #471 (comment) have been implemented. This repository, https://github.com/sebastianbergmann/phpunit-documentation, is now archived and read-only. The documentation for PHPUnit version prior to PHPUnit 7.0 will no longer be changed or updated. It is still hosted at
Simply replace Starting with the documentation for PHPUnit 7.0, the PHPUnit documentation is hosted at
I am sorry that I have to close this issue here as GitHub does not support moving issues from one project to another. Please open a new ticket for this issue in one of the new issue trackers (see above). |
http://phpunit.de/manual/current/en/database.html#database.composite-dataset
The documentation example calls
PHPUnit_Extensions_Database_DataSet_CompositeDataSet()
with no arguments, but it is wrong. It should be called with an array().Which is the meaning of that array? Also undocumented.
I only know that an empty array works because of http://someguyjeremy.com/blog/database-testing-with-phpunit
(footnote: actually, it doesn't work, it complains about
InvalidArgumentException: DataSet contains a table that already exists: foobar
)The text was updated successfully, but these errors were encountered: