Skip to content

Commit f4b18ab

Browse files
committed
refacotring Code
add some comment
1 parent 6f77f70 commit f4b18ab

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

Diff for: pymysqlreplication/row_event.py

+7-6
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ def _read_column_data(self, cols_bitmap, row_image_type=None):
115115
partial_bitmap = None
116116
if (
117117
self.event_type == BINLOG.PARTIAL_UPDATE_ROWS_EVENT
118-
and row_image_type == EnumRowImageType.UpdateAI
118+
and row_image_type == RowImageType.UpdateAI
119119
):
120120
binlog_row_value_option = self.packet.read_length_coded_binary()
121121
self.is_partial_json_update = binlog_row_value_option & 0b10000001 != 0
@@ -139,7 +139,7 @@ def _read_column_data(self, cols_bitmap, row_image_type=None):
139139

140140
if (
141141
self.is_partial_json_update
142-
and row_image_type == EnumRowImageType.UpdateAI
142+
and row_image_type == RowImageType.UpdateAI
143143
and column.type == FIELD_TYPE.JSON
144144
):
145145
if BitGet(partial_bitmap, partial_bitmap_index) > 0:
@@ -1171,12 +1171,12 @@ def __init__(self, from_packet, event_size, table_map, ctl_connection, **kwargs)
11711171

11721172
def _fetch_one_row(self):
11731173
row = {}
1174-
row_image_type = EnumRowImageType.UpdateBI
1174+
row_image_type = RowImageType.UpdateBI
11751175
row["before_values"] = self._read_column_data(
11761176
self.columns_present_bitmap, row_image_type
11771177
)
11781178
row["before_none_sources"] = self._get_none_sources(row["before_values"])
1179-
row_image_type = EnumRowImageType.UpdateAI
1179+
row_image_type = RowImageType.UpdateAI
11801180
row["after_values"] = self._read_column_data(
11811181
self.columns_present_bitmap2, row_image_type
11821182
)
@@ -1223,12 +1223,13 @@ def by_index(index):
12231223
return MetadataFieldType(index)
12241224

12251225

1226-
class EnumRowImageType(Enum):
1226+
class RowImageType(Enum):
1227+
# https://github.com/mysql/mysql-server/blob/1bfe02bdad6604d54913c62614bde57a055c8332/sql/rpl_record.h#L39
12271228
WriteAI = 0
12281229
UpdateBI = 1
12291230
UpdateAI = 2
12301231
DeleteBI = 3
12311232

12321233
@staticmethod
12331234
def by_index(index):
1234-
return EnumRowImageType(index)
1235+
return RowImageType(index)

0 commit comments

Comments
 (0)