Skip to content

Configurable extra runsBefore and runsAfter phases #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pbatko opened this issue May 9, 2016 · 2 comments
Closed

Configurable extra runsBefore and runsAfter phases #163

pbatko opened this issue May 9, 2016 · 2 comments

Comments

@pbatko
Copy link
Contributor

pbatko commented May 9, 2016

Currently scalac-scoverage-plugin runs after typer and before patmat phases. There are no other phases in between so the order is unique and fixed.

Situation changes when using other scalac plugins which add phases in between typer and patmat. Scoverage phase can be then nondeterministically inserted somewhere between these new phases.

To fine-tune phases ordering I propose adding following flags

-P:scoverage:extraAfterPhase:<phaseName>
-P:scoverage:extraBeforePhase:<phaseName>

which would specify what other phases beside typer and patmat need to taken into account when determining phase ordering by appending them to runsAfter and runsBefore lists.

PR: #164

What's your comments? Can we have these flags added?

@sksamuel
Copy link
Member

sksamuel commented Jun 2, 2016

This is now merged.

@sksamuel sksamuel closed this as completed Jun 2, 2016
@gslowikowski
Copy link
Member

What about documentation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants