Skip to content

Commit e5c998b

Browse files
authored
Merge pull request #179 from gslowikowski/build-fixes
Build fixes. Tests compatible with Scala 2.10 and 2.11 (previously only with 2.11)
2 parents 61534f1 + e6d9ef1 commit e5c998b

13 files changed

+42
-155
lines changed

.gitignore

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,20 @@
1-
*.class
21
*.log
32

4-
.idea
5-
.idea_modules
6-
7-
# sbt specific
8-
dist/*
3+
# SBT specific
94
target/
10-
lib_managed/
11-
src_managed/
125
project/boot/
136
project/plugins/project/
14-
credentials.sbt
15-
*.icode
167

178
# Eclipse specific
189
.classpath
1910
.project
2011
.settings/
2112

2213
# Scala-IDE specific
23-
.scala_dependencies
14+
.cache-main
15+
.cache-tests
16+
17+
# IntelliJ IDEA specific
18+
.idea
19+
.idea_modules
2420
*.iml

.travis.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
11
language: scala
2+
23
scala:
3-
- 2.11.4
4+
- 2.10.6
5+
- 2.11.8
6+
47
script:
5-
- "sbt clean test"
8+
- sbt ++$TRAVIS_SCALA_VERSION test
9+
610
jdk:
711
- oraclejdk7

project/EnvSupport.scala

Lines changed: 0 additions & 49 deletions
This file was deleted.

project/Scoverage.scala

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,15 @@ import org.scalajs.sbtplugin.ScalaJSPlugin.autoImport._
1111
object Scoverage extends Build {
1212

1313
val Org = "org.scoverage"
14-
val Scala = "2.11.7"
1514
val MockitoVersion = "1.9.5"
16-
val ScalatestVersion = "3.0.0-M15"
15+
val ScalatestVersion = "3.0.0"
1716

1817
lazy val LocalTest = config("local") extend Test
1918

2019
val appSettings = Seq(
2120
organization := Org,
22-
scalaVersion := Scala,
23-
crossScalaVersions := Seq("2.10.6", "2.11.7"),
21+
scalaVersion := "2.11.8",
22+
crossScalaVersions := Seq("2.10.6", "2.11.8"),
2423
fork in Test := false,
2524
publishMavenStyle := true,
2625
publishArtifact in Test := false,
@@ -70,7 +69,6 @@ object Scoverage extends Build {
7069
.settings(name := "scalac-scoverage")
7170
.settings(appSettings: _*)
7271
.settings(publishArtifact := false)
73-
.settings(javaOptions += "-XX:MaxMetaspaceSize=2048m")
7472
.aggregate(plugin, runtime.jvm, runtime.js)
7573

7674
lazy val runtime = CrossProject("scalac-scoverage-runtime", file("scalac-scoverage-runtime"), CrossType.Full)
@@ -80,8 +78,7 @@ object Scoverage extends Build {
8078
libraryDependencies ++= Seq(
8179
"org.mockito" % "mockito-all" % MockitoVersion % "test",
8280
"org.scalatest" %% "scalatest" % ScalatestVersion % "test"
83-
),
84-
javaOptions += "-XX:MaxMetaspaceSize=2048m"
81+
)
8582
)
8683
.jsSettings(
8784
libraryDependencies += "org.scalatest" %%% "scalatest" % ScalatestVersion,
@@ -95,7 +92,6 @@ object Scoverage extends Build {
9592
.dependsOn(`scalac-scoverage-runtimeJVM` % "test")
9693
.settings(name := "scalac-scoverage-plugin")
9794
.settings(appSettings: _*)
98-
.settings(javaOptions += "-XX:MaxMetaspaceSize=2048m")
9995
.settings(libraryDependencies ++= Seq(
10096
"org.mockito" % "mockito-all" % MockitoVersion % "test",
10197
"org.scalatest" %% "scalatest" % ScalatestVersion % "test",
@@ -107,10 +103,8 @@ object Scoverage extends Build {
107103
)).settings(libraryDependencies ++= {
108104
CrossVersion.partialVersion(scalaVersion.value) match {
109105
case Some((2, scalaMajor)) if scalaMajor == 11 =>
110-
EnvSupport.setEnv("CrossBuildScalaVersion", "2.11.7")
111106
Seq("org.scala-lang.modules" %% "scala-xml" % "1.0.4")
112107
case _ =>
113-
EnvSupport.setEnv("CrossBuildScalaVersion", "2.10.6")
114108
Nil
115109
}
116110
})

project/build.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
sbt.version=0.13.11
1+
sbt.version=0.13.12

project/scales-build.iml

Lines changed: 0 additions & 70 deletions
This file was deleted.

scalac-scoverage-plugin/src/test/scala/scoverage/CoberturaXmlWriterTest.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,8 @@ class CoberturaXmlWriterTest extends FunSuite with BeforeAndAfter with OneInstan
101101

102102
val xml = XML.loadFile(fileIn(dir))
103103

104-
assert(xml \\ "coverage" \@ "line-rate" === "0.33", "line-rate")
105-
assert(xml \\ "coverage" \@ "branch-rate" === "0.50", "branch-rate")
104+
assert((xml \\ "coverage" \ "@line-rate").text === "0.33", "line-rate")
105+
assert((xml \\ "coverage" \ "@branch-rate").text === "0.50", "branch-rate")
106106

107107
}
108108
}

scalac-scoverage-plugin/src/test/scala/scoverage/IOUtilsTest.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ package scoverage
33
import java.io.{File, FileWriter}
44
import java.util.UUID
55

6-
import org.scalatest.mock.MockitoSugar
6+
import org.scalatest.mockito.MockitoSugar
77
import org.scalatest.{FreeSpec, Matchers, OneInstancePerTest}
88

99
/** @author Stephen Samuel */

scalac-scoverage-plugin/src/test/scala/scoverage/PluginASTSupportTest.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package scoverage
22

3-
import org.scalatest.mock.MockitoSugar
3+
import org.scalatest.mockito.MockitoSugar
44
import org.scalatest._
55

66
/** @author Stephen Samuel */
@@ -98,7 +98,7 @@ class PluginASTSupportTest
9898
compiler.compileCodeSnippet( """object Foo {
9999
| final val foo = 1L
100100
|}
101-
|@SerialVersionUID(value = Foo.foo)
101+
|@SerialVersionUID(Foo.foo)
102102
|class Bar
103103
|""".stripMargin)
104104
assert(!compiler.reporter.hasErrors)

scalac-scoverage-plugin/src/test/scala/scoverage/PluginCoverageTest.scala

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package scoverage
22

3-
import org.scalatest.mock.MockitoSugar
3+
import org.scalatest.mockito.MockitoSugar
44
import org.scalatest.{BeforeAndAfterEachTestData, FunSuite, OneInstancePerTest}
55

66
/** @author Stephen Samuel */
@@ -27,7 +27,19 @@ class PluginCoverageTest
2727

2828
test("scoverage should skip macros") {
2929
val compiler = ScoverageCompiler.default
30-
val code = """
30+
val code = if (ScoverageCompiler.ShortScalaVersion == "2.10")
31+
"""
32+
import scala.language.experimental.macros
33+
import scala.reflect.macros.Context
34+
object Impl {
35+
def poly[T: c.WeakTypeTag](c: Context) = c.literal(c.weakTypeOf[T].toString)
36+
}
37+
38+
object Macros {
39+
def poly[T] = macro Impl.poly[T]
40+
}"""
41+
else
42+
"""
3143
import scala.language.experimental.macros
3244
import scala.reflect.macros.Context
3345
class Impl(val c: Context) {

scalac-scoverage-plugin/src/test/scala/scoverage/RegexCoverageFilterTest.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package scoverage
22

33
import org.mockito.Mockito
4-
import org.scalatest.mock.MockitoSugar
4+
import org.scalatest.mockito.MockitoSugar
55
import org.scalatest.{FreeSpec, Matchers}
66

77
import scala.reflect.internal.util._

scalac-scoverage-plugin/src/test/scala/scoverage/ScoverageCompiler.scala

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import scala.tools.nsc.transform.{Transform, TypingTransformers}
1111
/** @author Stephen Samuel */
1212
object ScoverageCompiler {
1313

14-
val ScalaVersion = "2.11.7"
14+
val ScalaVersion = scala.util.Properties.versionNumberString
1515
val ShortScalaVersion = ScalaVersion.dropRight(2)
1616

1717
def classPath = getScalaJars.map(_.getAbsolutePath) :+ sbtCompileDir.getAbsolutePath :+ runtimeClasses.getAbsolutePath
@@ -45,13 +45,13 @@ object ScoverageCompiler {
4545
}
4646

4747
private def sbtCompileDir: File = {
48-
val dir = new File("./scalac-scoverage-plugin/target/scala-" + ShortScalaVersion + "/classes")
48+
val dir = new File(s"./scalac-scoverage-plugin/target/scala-$ShortScalaVersion/classes")
4949
if (!dir.exists)
5050
throw new FileNotFoundException(s"Could not locate SBT compile directory for plugin files [$dir]")
5151
dir
5252
}
5353

54-
private def runtimeClasses: File = new File("./scalac-scoverage-runtime/jvm/target/scala-2.11/classes")
54+
private def runtimeClasses: File = new File(s"./scalac-scoverage-runtime/jvm/target/scala-$ShortScalaVersion/classes")
5555

5656
private def findScalaJar(artifactId: String): File = findIvyJar("org.scala-lang", artifactId, ScalaVersion)
5757

scalac-scoverage-plugin/src/test/scala/scoverage/SerializerTest.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ package scoverage
33
import java.io.StringWriter
44

55
import org.scalatest.{OneInstancePerTest, FunSuite}
6-
import org.scalatest.mock.MockitoSugar
6+
import org.scalatest.mockito.MockitoSugar
77

88
import scala.xml.Utility
99

0 commit comments

Comments
 (0)