Skip to content

Commit 89f5846

Browse files
committed
Merge pull request #94 from Kwestor/refactor/use-reporter
Use reporter from scalac Global to print messages
2 parents ca46b08 + d5c93ab commit 89f5846

File tree

1 file changed

+10
-10
lines changed
  • scalac-scoverage-plugin/src/main/scala/scoverage

1 file changed

+10
-10
lines changed

scalac-scoverage-plugin/src/main/scala/scoverage/plugin.scala

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -82,19 +82,19 @@ class ScoverageInstrumentationComponent(val global: Global)
8282
override def newPhase(prev: scala.tools.nsc.Phase): Phase = new Phase(prev) {
8383

8484
override def run(): Unit = {
85-
println(s"[info] Cleaning datadir [${options.dataDir}]")
85+
reporter.echo(s"[info] Cleaning datadir [${options.dataDir}]")
8686
// we clean the data directory, because if the code has changed, then the number / order of
8787
// statements has changed by definition. So the old data would reference statements incorrectly
8888
// and thus skew the results.
8989
IOUtils.clean(options.dataDir)
9090

91-
println("[info] Beginning coverage instrumentation")
91+
reporter.echo("[info] Beginning coverage instrumentation")
9292
super.run()
93-
println(s"[info] Instrumentation completed [${coverage.statements.size} statements]")
93+
reporter.echo(s"[info] Instrumentation completed [${coverage.statements.size} statements]")
9494

9595
Serializer.serialize(coverage, Serializer.coverageFile(options.dataDir))
96-
println(s"[info] Wrote instrumentation file [${Serializer.coverageFile(options.dataDir)}]")
97-
println(s"[info] Will write measurement data to [${options.dataDir}]")
96+
reporter.echo(s"[info] Wrote instrumentation file [${Serializer.coverageFile(options.dataDir)}]")
97+
reporter.echo(s"[info] Will write measurement data to [${options.dataDir}]")
9898
}
9999
}
100100

@@ -163,7 +163,7 @@ class ScoverageInstrumentationComponent(val global: Global)
163163
def instrument(tree: Tree, original: Tree, branch: Boolean = false): Tree = {
164164
safeSource(tree) match {
165165
case None =>
166-
println(s"[warn] Could not instrument [${tree.getClass.getSimpleName}/${tree.symbol}]. No pos.")
166+
reporter.echo(s"[warn] Could not instrument [${tree.getClass.getSimpleName}/${tree.symbol}]. No pos.")
167167
tree
168168
case Some(source) =>
169169
if (tree.pos.isDefined && !isStatementIncluded(tree.pos)) {
@@ -198,7 +198,7 @@ class ScoverageInstrumentationComponent(val global: Global)
198198
def updateLocation(t: Tree) {
199199
Location(global)(t) match {
200200
case Some(loc) => this.location = loc
201-
case _ => println(s"[warn] Cannot update location for $t")
201+
case _ => reporter.warning(t.pos, s"[warn] Cannot update location for $t")
202202
}
203203
}
204204

@@ -218,7 +218,7 @@ class ScoverageInstrumentationComponent(val global: Global)
218218
)
219219
)
220220
case _ =>
221-
println("Cannot instrument partial function apply. Please file bug report")
221+
reporter.error(c.pos ,"Cannot instrument partial function apply. Please file bug report")
222222
d
223223
}
224224
case other => other
@@ -229,7 +229,7 @@ class ScoverageInstrumentationComponent(val global: Global)
229229

230230
def debug(t: Tree) {
231231
import scala.reflect.runtime.{universe => u}
232-
println(t.getClass.getSimpleName + ": LINE " + safeLine(t) + ": " + u.showRaw(t))
232+
reporter.echo(t.getClass.getSimpleName + ": LINE " + safeLine(t) + ": " + u.showRaw(t))
233233
}
234234

235235
def traverseApplication(t: Tree): Tree = {
@@ -593,7 +593,7 @@ class ScoverageInstrumentationComponent(val global: Global)
593593
treeCopy.ValDef(tree, v.mods, v.name, v.tpt, process(v.rhs))
594594

595595
case _ =>
596-
println("BUG: Unexpected construct: " + tree.getClass + " " + tree.symbol)
596+
reporter.warning(tree.pos, "BUG: Unexpected construct: " + tree.getClass + " " + tree.symbol)
597597
super.transform(tree)
598598
}
599599
}

0 commit comments

Comments
 (0)