Skip to content

ScalaJS CrossProject incompatible issue #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue Jun 1, 2015 · 9 comments
Closed

ScalaJS CrossProject incompatible issue #111

ghost opened this issue Jun 1, 2015 · 9 comments
Labels

Comments

@ghost
Copy link

ghost commented Jun 1, 2015

The ScalaJS CrossProject class "shares" code between JS/JVM builds by adding a path to the build. This causes the build to fail and in this case we only build fro JVM:

No source root found for

/home/travis/build/InTheNow/cats/state/jvm/../shared/src/main/scala/cats/state/State.scala (source roots: /home/travis/build/InTheNow/cats/state/shared/src/main/scala/)

ref https://travis-ci.org/InTheNow/cats/builds/64943666

CC @sjrd

@hawkw
Copy link

hawkw commented Jul 3, 2015

👍

1 similar comment
@alexarchambault
Copy link

+1

@ngbinh
Copy link

ngbinh commented Jul 7, 2015

💯

@alexarchambault
Copy link

@hawkw
Copy link

hawkw commented Jul 7, 2015

I am fairly sure that this issue has actually been fixed in Scala.js; just make sure you're using Scala.js v0.6.4 rather than v0.6.3 (which I believe is still mentioned in some of the Scala.js sample material).

@alexarchambault
Copy link

I was using scalajs 0.6.3 indeed (I switched to 0.6.4 a few minutes ago).

@alexarchambault
Copy link

This is better with scalajs 0.6.4 (and SBT 0.13.8 / scala 2.11.7, I can get a report for JVM projects at least). @hawkw Thanks!

@fthomas
Copy link

fthomas commented Jul 7, 2015

I can confirm that this seems to be working for me too with Scala.js 0.6.4.

@ckipp01
Copy link
Member

ckipp01 commented Apr 28, 2021

This seems to have been fixed. If there is still an issue here, please do comment back.

@ckipp01 ckipp01 closed this as completed Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants