Skip to content

Commit 7a17425

Browse files
committed
wip
1 parent 2d8486f commit 7a17425

File tree

17 files changed

+36
-40
lines changed

17 files changed

+36
-40
lines changed

.github/workflows/pr.yml

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,7 @@ jobs:
1414
matrix:
1515
java: [ '11' ]
1616
scala: [
17-
{ version: '2.12.13' },
18-
{ version: '2.12.12' },
19-
{ version: '2.12.11' },
20-
{ version: '2.12.10' },
21-
{ version: '2.13.4' },
22-
{ version: '2.13.3' },
23-
{ version: '2.13.2' },
24-
{ version: '2.13.1' },
25-
{ version: '2.13.0' }
17+
{ version: '2.12.13' }
2618
]
2719
steps:
2820
- name: checkout the repo

build.sbt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,12 @@ resolvers ++= {
1010
if (isSnapshot.value) Seq(Resolver.sonatypeRepo("snapshots")) else Nil
1111
}
1212

13-
libraryDependencies += "org.scoverage" %% "scalac-scoverage-plugin" % "1.4.2"
13+
libraryDependencies +=
14+
"org.scoverage" %% "scalac-scoverage-plugin" % "1.4.3-SNAPSHOT" cross CrossVersion.full
1415

1516
publishMavenStyle := true
1617

17-
publishArtifact in Test := false
18+
Test / publishArtifact := false
1819

1920
scriptedLaunchOpts ++= Seq(
2021
"-Xmx1024M",

project/build.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
sbt.version=1.2.8
1+
sbt.version=1.5.1

src/main/scala/scoverage/ScoverageSbtPlugin.scala

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ object ScoverageSbtPlugin extends AutoPlugin {
1111
val ScalacRuntimeArtifact = "scalac-scoverage-runtime"
1212
val ScalacPluginArtifact = "scalac-scoverage-plugin"
1313
// this should match the version defined in build.sbt
14-
val DefaultScoverageVersion = "1.4.2"
14+
val DefaultScoverageVersion = "1.4.3-SNAPSHOT"
1515
val autoImport = ScoverageKeys
1616
lazy val ScoveragePluginConfig = config("scoveragePlugin").hide
1717

@@ -48,7 +48,7 @@ object ScoverageSbtPlugin extends AutoPlugin {
4848
ivyConfigurations += ScoveragePluginConfig,
4949
coverageReport := coverageReport0.value,
5050
coverageAggregate := coverageAggregate0.value,
51-
aggregate in coverageAggregate := false
51+
coverageAggregate / aggregate := false
5252
) ++ coverageSettings ++ scalacSettings
5353

5454
private lazy val coverageSettings = Seq(
@@ -57,7 +57,8 @@ object ScoverageSbtPlugin extends AutoPlugin {
5757
Seq(
5858
// We only add for "compile" because of macros. This setting could be optimed to just "test" if the handling
5959
// of macro coverage was improved.
60-
(OrgScoverage %% (scalacRuntime(libraryDependencies.value)) % coverageScalacPluginVersion.value).cross(CrossVersion.full),
60+
(OrgScoverage %% ScalacRuntimeArtifact % coverageScalacPluginVersion.value).cross(CrossVersion.full),
61+
//(OrgScoverage %% (scalacRuntime(libraryDependencies.value)) % coverageScalacPluginVersion.value).cross(CrossVersion.full),
6162
// We don't want to instrument the test code itself, nor add to a pom when published with coverage enabled.
6263
(OrgScoverage %% ScalacPluginArtifact % coverageScalacPluginVersion.value % ScoveragePluginConfig.name).cross(CrossVersion.full)
6364
)
@@ -67,7 +68,7 @@ object ScoverageSbtPlugin extends AutoPlugin {
6768
)
6869

6970
private lazy val scalacSettings = Seq(
70-
scalacOptions in(Compile, compile) ++= {
71+
Compile / compile / scalacOptions ++= {
7172
val updateReport = update.value
7273
if (coverageEnabled.value) {
7374
val scoverageDeps: Seq[File] = updateReport matching configurationFilter(ScoveragePluginConfig.name)
@@ -113,14 +114,14 @@ object ScoverageSbtPlugin extends AutoPlugin {
113114
case Some(cov) =>
114115
writeReports(
115116
target,
116-
(sourceDirectories in Compile).value,
117+
(Compile / sourceDirectories).value,
117118
cov,
118119
coverageOutputCobertura.value,
119120
coverageOutputXML.value,
120121
coverageOutputHTML.value,
121122
coverageOutputDebug.value,
122123
coverageOutputTeamCity.value,
123-
sourceEncoding((scalacOptions in (Compile)).value),
124+
sourceEncoding((Compile / scalacOptions).value),
124125
log)
125126

126127
checkCoverage(cov, log, coverageMinimum.value, coverageFailOnMinimum.value)
@@ -144,7 +145,7 @@ object ScoverageSbtPlugin extends AutoPlugin {
144145
coverageOutputHTML.value,
145146
coverageOutputDebug.value,
146147
coverageOutputTeamCity.value,
147-
sourceEncoding((scalacOptions in (Compile)).value),
148+
sourceEncoding((Compile / scalacOptions).value),
148149
log)
149150
val cfmt = cov.statementCoverageFormatted
150151
log.info(s"Aggregation complete. Coverage was [$cfmt]")

src/sbt-test/scoverage/aggregate-only/build.sbt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
lazy val commonSettings = Seq(
77
organization := "org.scoverage",
88
version := "0.1.0",
9-
scalaVersion := "2.12.8"
9+
scalaVersion := "2.12.13"
1010
)
1111

1212
lazy val specs2Lib = "org.specs2" %% "specs2" % "2.5" % "test"

src/sbt-test/scoverage/aggregate/build.sbt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
lazy val commonSettings = Seq(
77
organization := "org.scoverage",
88
version := "0.1.0",
9-
scalaVersion := "2.12.8"
9+
scalaVersion := "2.12.13"
1010
)
1111

1212
lazy val specs2Lib = "org.specs2" %% "specs2" % "2.5" % "test"

src/sbt-test/scoverage/bad-coverage/build.sbt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
version := "0.1"
22

3-
scalaVersion := "2.12.8"
3+
scalaVersion := "2.12.13"
44

55
libraryDependencies += "org.specs2" %% "specs2" % "2.5" % "test"
66

src/sbt-test/scoverage/coverage-off/build.sbt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
version := "0.1"
22

3-
scalaVersion := "2.12.8"
3+
scalaVersion := "2.12.13"
44

55
libraryDependencies += "org.specs2" %% "specs2" % "2.5" % "test"
66

src/sbt-test/scoverage/good-coverage/build.sbt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
version := "0.1"
22

3-
scalaVersion := "2.12.8"
3+
scalaVersion := "2.12.13"
44

55
libraryDependencies += "org.specs2" %% "specs2" % "2.5" % "test"
66

src/sbt-test/scoverage/preserve-set/build.sbt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ import sbt.complete.DefaultParsers._
22

33
version := "0.1"
44

5-
scalaVersion := "2.12.8"
5+
scalaVersion := "2.12.13"
66

7-
crossScalaVersions := Seq("2.10.6", "2.12.8")
7+
crossScalaVersions := Seq("2.10.6", "2.12.13")
88

99
libraryDependencies += "org.specs2" %% "specs2" % "2.5" % "test"
1010

src/sbt-test/scoverage/preserve-set/test

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
# check scalaVersion setting
2-
> checkScalaVersion "2.12.8"
2+
> checkScalaVersion "2.12.13"
33
> checkScoverageEnabled "false"
44
> coverage
55
> checkScoverageEnabled "true"
66
> coverageOff
7-
> checkScalaVersion "2.12.8"
7+
> checkScalaVersion "2.12.13"
88
> checkScoverageEnabled "false"
99
# changs scala version
1010
> ++2.10.6

src/sbt-test/scoverage/scalajs/build.sbt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,10 @@ import sbtcrossproject.CrossType
44
lazy val root = (project in file(".")).aggregate(crossJS, crossJVM)
55

66
lazy val cross = CrossProject("sjstest", file("sjstest"))(JVMPlatform, JSPlatform)
7-
.crossType(CrossType.Full)
87
.settings(
9-
scalaVersion := "2.12.8",
8+
scalaVersion := "2.13.5",
109
libraryDependencies ++= Seq(
11-
"org.scalatest" %%% "scalatest" % "3.0.0" % "test"
10+
"org.scalatest" %%% "scalatest" % "3.2.8" % "test"
1211
)
1312
)
1413

src/sbt-test/scoverage/scalajs/project/plugins.sbt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,6 @@ resolvers ++= {
1313
Seq.empty
1414
}
1515

16-
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.27")
16+
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "1.5.1")
1717

18-
addSbtPlugin("org.portable-scala" % "sbt-scalajs-crossproject" % "0.6.0")
18+
addSbtPlugin("org.portable-scala" % "sbt-scalajs-crossproject" % "1.0.0")

src/sbt-test/scoverage/scalajs/sjstest/js/src/test/scala/JsTest.scala

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1-
import org.scalatest.{FlatSpec, Matchers}
1+
import org.scalatest.flatspec.AnyFlatSpec
2+
import org.scalatest.matchers.should.Matchers
23

3-
class JsTest extends FlatSpec with Matchers {
4+
class JsTest extends AnyFlatSpec with Matchers {
45

56
"JS UnderTest" should "work on JS" in {
67
UnderTest.jsMethod shouldBe "js"

src/sbt-test/scoverage/scalajs/sjstest/jvm/src/test/scala/JvmTest.scala

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1-
import org.scalatest.{FlatSpec, Matchers}
1+
import org.scalatest.flatspec.AnyFlatSpec
2+
import org.scalatest.matchers.should.Matchers
23

3-
class JvmTest extends FlatSpec with Matchers {
4+
class JvmTest extends AnyFlatSpec with Matchers {
45

56
"JVM UnderTest" should "work on JVM" in {
67
UnderTest.jvmMethod shouldBe "jvm"

src/sbt-test/scoverage/scalajs/sjstest/shared/src/test/scala/SharedTest.scala

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1-
import org.scalatest.{FlatSpec, Matchers}
1+
import org.scalatest.flatspec.AnyFlatSpec
2+
import org.scalatest.matchers.should.Matchers
23

3-
class SharedTest extends FlatSpec with Matchers {
4+
class SharedTest extends AnyFlatSpec with Matchers {
45

56
"Shared UnderTest" should "return where it works" in {
67
UnderTest.onJsAndJvm shouldBe "js and jvm"

version.sbt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
version in ThisBuild := "1.6.2-SNAPSHOT"
1+
(ThisBuild / version) := "1.6.2-SNAPSHOT"

0 commit comments

Comments
 (0)