Skip to content

Issue with oldest-supported-numpy package approach and pip 22.1 build validation with --no-build-isolation #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lesteve opened this issue May 12, 2022 · 2 comments

Comments

@lesteve
Copy link

lesteve commented May 12, 2022

  • pip 22.1 (released recently on May 11) validates build requirements from pyproject.toml when using --no-build-isolation issue and PR
  • in scikit-learn we have oldest-supported-numpy in our pyproject.toml build requirements as advised in your README. I am guessing this is the case for a number of other projects (e.g. pandas does something similar)
  • Trying to do pip install --no-build-isolation . will error with a message like this:
    Some build dependencies for file:///home/local/lesteve/dev/scikit-learn are missing: 'oldest-supported-   numpy'.`
    
  • we also saw some issue in conda-forge with a similar error: Release 1.1.0 conda-forge/scikit-learn-feedstock#186 (comment) (I am guessing that conda-build is using --no-build-isolation)

Any suggestions on how to handle the situation nicely would be more than welcome! As a short-term fix, we have pinned pip to 22.0.4.

To reproduce with scikit-learn:

mamba create -n test cython scipy 'setuptools<60' -y
git clone https://github.com/scikit-learn/scikit-learn
cd scikit-learn
pip install --no-build-isolation .

Error

ERROR: Some build dependencies for file:///home/local/lesteve/dev/scikit-learn are missing: 'oldest-supported-numpy'.
@rgommers
Copy link
Member

Argh! Thanks for the report @lesteve. That seems like a clear oversight in the Pip PR that introduced this behavior. A pin sounds right as a workaround, I'll go ask for a fix in Pip itself.

@lesteve
Copy link
Author

lesteve commented May 24, 2022

pip 22.1.1 has been released with the fix from pypa/pip@30af807. Closing this one, thanks a lot for reporting the issue in the pip issue tracker!

@lesteve lesteve closed this as completed May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants