Skip to content

Commit 24773a9

Browse files
ragrawalragrawal
and
ragrawal
authored
Bug Fixes (#236)
* Calling super on setstate * added check for 3.9 * deprecated support for Python 3.6 Co-authored-by: ragrawal <[email protected]>
1 parent b897c66 commit 24773a9

File tree

5 files changed

+27
-7
lines changed

5 files changed

+27
-7
lines changed

.circleci/config.yml

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,31 @@
11
version: 2
22
jobs:
3-
test:
3+
test37:
44
docker:
5-
- image: circleci/python:3.6
5+
- image: circleci/python:3.7
66
steps:
77
- checkout
88
- run: pip install --user nox
99
- run: ~/.local/bin/nox
10+
test38:
11+
docker:
12+
- image: circleci/python:3.8
13+
steps:
14+
- checkout
15+
- run: pip install --user nox
16+
- run: ~/.local/bin/nox
17+
test39:
18+
docker:
19+
- image: circleci/python:3.9
20+
steps:
21+
- checkout
22+
- run: pip install --user nox
23+
- run: ~/.local/bin/nox
1024

1125
workflows:
1226
version: 2
1327
build_and_test:
1428
jobs:
15-
- test
29+
- test37
30+
- test38
31+
- test39

.github/workflows/python-publish.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
runs-on: ubuntu-latest
1414
strategy:
1515
matrix:
16-
python-version: [3.6, 3.7, 3.8]
16+
python-version: [3.7, 3.8, 3.9]
1717
steps:
1818
- uses: actions/checkout@v2
1919
- name: Set up Python ${{ matrix.python-version }}

README.rst

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -455,6 +455,9 @@ Below example shows how to change logging level.
455455
Changelog
456456
---------
457457

458+
* Fix bug with `__setstate__` method. Calling super so that mixin such as baikal can work properly
459+
* adding test for Python 3.9
460+
458461
2.0.4 (2020-11-06)
459462
******************
460463

noxfile.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@ def lint(session):
99
session.run('flake8', 'sklearn_pandas/', 'tests')
1010

1111
@nox.session
12-
@nox.parametrize('numpy', ['1.18.1', '1.19.4'])
13-
@nox.parametrize('scipy', ['1.4.1', '1.5.4'])
14-
@nox.parametrize('pandas', ['1.0.5', '1.1.4'])
12+
@nox.parametrize('numpy', ['1.18.1', '1.19.4', '1.20.1'])
13+
@nox.parametrize('scipy', ['1.4.1', '1.5.4', '1.6.0'])
14+
@nox.parametrize('pandas', ['1.0.5', '1.1.4', '1.2.2'])
1515
def tests(session, numpy, scipy, pandas):
1616
session.install('pytest==5.3.5',
1717
'setuptools==45.2',

sklearn_pandas/dataframe_mapper.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,7 @@ def _unselected_columns(self, X):
156156

157157
def __setstate__(self, state):
158158
# compatibility for older versions of sklearn-pandas
159+
super().__setstate__(state)
159160
self.features = [_build_feature(*feat) for feat in state['features']]
160161
self.sparse = state.get('sparse', False)
161162
self.default = state.get('default', False)

0 commit comments

Comments
 (0)