Skip to content

Commit d511b0a

Browse files
committed
use unit test provided assertion methods
1 parent 9d90053 commit d511b0a

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

category_encoders/tests/test_encoders.py

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import pandas as pd
44
import category_encoders as encoders
55
import numpy as np
6-
from math import isclose
76

87
__author__ = 'willmcginnis'
98

@@ -644,9 +643,9 @@ def test_fit_HaveConstructorSetSmoothingAndMinSamplesLeaf_ExpectUsedInFit(self):
644643
encoder.fit(binary_cat_example, binary_cat_example['target'])
645644
trend_mapping = encoder.mapping[0]['mapping']
646645

647-
assert isclose(0.4125, trend_mapping['DOWN']['smoothing'], abs_tol=1e-4)
648-
assert isclose(.5, trend_mapping['FLAT']['smoothing'], abs_tol=1e-4)
649-
assert isclose(0.5874, trend_mapping['UP']['smoothing'], abs_tol=1e-4)
646+
self.assertAlmostEquals(0.4125, trend_mapping['DOWN']['smoothing'], delta=1e-4)
647+
self.assertEqual(0.5, trend_mapping['FLAT']['smoothing'])
648+
self.assertAlmostEquals(0.5874, trend_mapping['UP']['smoothing'], delta=1e-4)
650649

651650
def test_fit_transform_HaveConstructorSetSmoothingAndMinSamplesLeaf_ExpectCorrectValueInResult(self):
652651
"""
@@ -663,7 +662,7 @@ def test_fit_transform_HaveConstructorSetSmoothingAndMinSamplesLeaf_ExpectCorrec
663662
result = encoder.fit_transform(binary_cat_example, binary_cat_example['target'])
664663
values = result['Trend'].values
665664

666-
assert isclose(0.5874, values[0], abs_tol=1e-4)
667-
assert isclose(0.5874, values[1], abs_tol=1e-4)
668-
assert isclose(0.4125, values[2], abs_tol=1e-4)
669-
assert isclose(0.5, values[3], abs_tol=1e-4)
665+
self.assertAlmostEquals(0.5874, values[0], delta=1e-4)
666+
self.assertAlmostEquals(0.5874, values[1], delta=1e-4)
667+
self.assertAlmostEquals(0.4125, values[2], delta=1e-4)
668+
self.assertEqual(0.5, values[3])

0 commit comments

Comments
 (0)