Skip to content

Commit a98a8cc

Browse files
committed
Merge remote-tracking branch 'upstream/master' into ordinal-encoder-support-new-handle-unknown-handle-missing
2 parents 109a3d6 + 41eb0cd commit a98a8cc

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

CONTRIBUTING.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ The preferred workflow to contribute to git-pandas is:
3131
Guidelines
3232
==========
3333

34-
Git-pandas is still a very young project, but we do have a few guiding principles:
34+
This is still a very young project, but we do have a few guiding principles:
3535

3636
1. Maintain semantics of the scikit-learn API
3737
2. Write detailed docstrings in numpy format
@@ -46,7 +46,9 @@ To run the tests, use:
4646
$ nosetests --with-coverage
4747
$ coverage html
4848

49+
Run the tests with both, Python3 and Python2.
50+
4951
Easy Issues / Getting Started
5052
=============================
5153

52-
There are usually some issues in the project github page looking for contributors, if not you're welcome to propose some ideas there, or a great first step is often to just use the library, and add to the examples directory. This helps us with documentation, and often helps to find things that would make the library better to use.
54+
There are usually some issues in the project github page looking for contributors, if not you're welcome to propose some ideas there, or a great first step is often to just use the library, and add to the examples directory. This helps us with documentation, and often helps to find things that would make the library better to use.

category_encoders/basen.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import pandas as pd
44
import numpy as np
55
import math
6-
import warnings
76
from sklearn.base import BaseEstimator, TransformerMixin
87
from category_encoders.ordinal import OrdinalEncoder
98
import category_encoders.utils as util
@@ -255,7 +254,6 @@ def inverse_transform(self, X_in):
255254
256255
"""
257256

258-
warnings.warn('Inverse transform in basen is a currently experimental feature, please be careful')
259257
X = X_in.copy(deep=True)
260258

261259
# first check the type

0 commit comments

Comments
 (0)