Skip to content

Should cmake be listed as a dependency in pyproject.toml ? #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mayeut opened this issue May 20, 2021 · 1 comment · Fixed by #45
Closed

Should cmake be listed as a dependency in pyproject.toml ? #44

mayeut opened this issue May 20, 2021 · 1 comment · Fixed by #45

Comments

@mayeut
Copy link
Contributor

mayeut commented May 20, 2021

requires = ["setuptools>=42", "wheel", "scikit-build", "cmake"]

I used this dependency to fix the SDist test in #43 but on second thought, it's not strictly required. CMake is required but if it's already on the system, then adding this might cause more harm than good ? (e.g. on alpine)

@henryiii
Copy link
Contributor

I think we have to break the cycle somewhere, so probably yes, this should not be included?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants