Skip to content

Commit c7dd4f1

Browse files
authored
fix(ci): test_sdist shall not test wheels installation (#65)
There's a race condition in the jobs meaning `dist` will be populated by the the sdist and any number of wheels. If there's more than one wheel, sdist tests will fail. We do not require tests in test_distribution.py which are meant for local builds. Rather than excluding these tests, simply do not provide a `dist` folder to look at. It keeps the workflow simpler and if anyone tries to reproduce locally they will run these tests which are meant to be run locally.
1 parent 0c8c262 commit c7dd4f1

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,12 +98,12 @@ jobs:
9898
- uses: actions/download-artifact@v2
9999
with:
100100
name: artifact
101-
path: dist
101+
path: sdist
102102

103103
- name: Install SDist
104104
env:
105105
SKBUILD_CONFIGURE_OPTIONS: "-DBUILD_CMAKE_FROM_SOURCE:BOOL=OFF"
106-
run: pip install dist/*.tar.gz
106+
run: pip install sdist/*.tar.gz
107107

108108
- name: Install test dependencies
109109
run: pip install -r requirements-test.txt

0 commit comments

Comments
 (0)