👌review

Author: yazgoo

sbt-plugin/src/main/scala/ch/epfl/scala/AnalyzeDependencyGraph.scala

@@ -52,18 +52,20 @@ object AnalyzeDependencyGraph {
       }
     }.failOnException
 
-  private def analyzeDependencies(state: State, params: AnalysisParams): State =
-    (for {
+  private def analyzeDependencies(state: State, params: AnalysisParams): State = {
+    for {
       repo <- params.repository.orElse(getGitHubRepo)
       vulnerabilities <- downloadAlerts(state, repo) match {
         case Success(v) => Some(v)
         case Failure(e) =>
           state.log.error(s"Failed to download alerts: ${e.getMessage}")
           None
       }
-    } yield analyzeCves(state, vulnerabilities)).getOrElse(state)
+    } yield analyzeCves(state, vulnerabilities) 
+    state
+  }
 
-  private def analyzeCves(state: State, vulnerabilities: Seq[Vulnerability]): State = {
+  private def analyzeCves(state: State, vulnerabilities: Seq[Vulnerability]): Unit = {
     val artifacts = getAllArtifacts(state)
     vulnerabilities.foreach { v =>
       val (goodMatches, badMatches) = vulnerabilityMatchesArtifacts(v, artifacts)
@@ -75,7 +77,6 @@ object AnalyzeDependencyGraph {
         println("    🎉 no match (dependency was probably removed)")
       }
     }
-    state
   }
 
   private def getStateOrWarn[T](state: State, key: AttributeKey[T], what: String, command: String): Option[T] =

sbt-plugin/src/main/scala/ch/epfl/scala/GithubDependencyGraphPlugin.scala

@@ -32,7 +32,6 @@ object GithubDependencyGraphPlugin extends AutoPlugin {
     val githubManifestsKey: AttributeKey[Map[String, githubapi.Manifest]] = AttributeKey("githubDependencyManifests")
     val githubProjectsKey: AttributeKey[Seq[ProjectRef]] = AttributeKey("githubProjectRefs")
     val githubSnapshotFileKey: AttributeKey[File] = AttributeKey("githubSnapshotFile")
-    val githubAlertsKey: AttributeKey[Seq[AnalyzeDependencyGraph.Vulnerability]] = AttributeKey("githubAlerts")
 
     val githubDependencyManifest: TaskKey[Option[githubapi.Manifest]] = taskKey(
       "The dependency manifest of the project"