Fix #140: Identify nameless given declarations

Author: nicolasstucki

src/typescript/Scala.tmLanguage.ts

@@ -708,12 +708,17 @@ export const scalaTmLanguage: TmLanguage = {
           name: 'meta.package.scala'
         },
         {
-          match: `\\b(given)\\b\\s*(?:\\b(as)\\b|(${idUpper})|(${backQuotedId}|(?!//|/\\*)${plainid})?)`,
+          match: `\\b(given)\\s+(?:(${idUpper})|(${backQuotedId}|${plainid}))?(?=[^;]+\\bas\\b)`,
+          captures: {
+            '1': { name: 'keyword.declaration.scala' },
+            '2': { name: 'entity.name.type.declaration' },
+            '3': { name: 'entity.name.declaration' },
+          }
+        },
+        {
+          match: `\\b(given)\\b`,
           captures: {
             '1': { name: 'keyword.declaration.scala' },
-            '2': { name: 'keyword.declaration.scala' },
-            '3': { name: 'entity.name.type.declaration' },
-            '4': { name: 'entity.name.declaration' },
           }
         }
       ]

tests/unit/#103.test.scala

@@ -43,7 +43,7 @@
 
     given foo[X <: Y { type A = 1; def f(using a: Int): 2 }](x: X = 2) as Foo = ...
 //  ^^^^^ keyword.declaration.scala
-//        ^^^ entity.name.declaration
+///        ^^^ entity.name.declaration // disabled: heuristic identifis `;` as end of `given` definition
 //                     ^^^^ keyword.declaration.scala
 //                              ^ constant.numeric.scala
 //                                 ^^^ keyword.declaration.scala

tests/unit/#140.test.scala

@@ -0,0 +1,11 @@
+// SYNTAX TEST "source.scala"
+
+   given foo.Foo
+// ^^^^^ keyword.declaration.scala
+//       ^^^ - entity.name.declaration
+//           ^^^ entity.name.class
+
+   given Foo[a]
+// ^^^^^ keyword.declaration.scala
+//       ^^^ - entity.name.type.declaration
+//       ^^^ entity.name.class

tests/unit/given.test.scala

@@ -3,11 +3,13 @@
 
     given Foo = ???
 //  ^^^^^ keyword.declaration.scala
-//        ^^^ entity.name.type.declaration
+//        ^^^ - entity.name.type.declaration
+//        ^^^ entity.name.class
 
     given foo = ???
 //  ^^^^^ keyword.declaration.scala
-//        ^^^ entity.name.declaration
+//        ^^^ - entity.name.declaration
+//        ^^^ source.scala
 
     given as Foo = ???
 //  ^^^^^ keyword.declaration.scala
@@ -30,3 +32,20 @@
 //        ^^^ entity.name.type.declaration
 //            ^^ keyword.declaration.scala
 //               ^^^ source.scala
+
+    given foo = ???; given Bar as Baz
+//  ^^^^^ keyword.declaration.scala
+//        ^^^ - entity.name.type.declaration
+//                   ^^^^^ keyword.declaration.scala
+//                         ^^^ entity.name.type.declaration
+//                             ^^ keyword.declaration.scala
+//                                ^^^ entity.name.class
+
+    given Foo = ???; given Bar as Baz
+//  ^^^^^ keyword.declaration.scala
+//        ^^^ - entity.name.type.declaration
+//        ^^^ entity.name.class
+//                   ^^^^^ keyword.declaration.scala
+//                         ^^^ entity.name.type.declaration
+//                             ^^ keyword.declaration.scala
+//                                ^^^ entity.name.class