Skip to content

Commit 5715523

Browse files
authored
Merge pull request #41 from PanAeon/feature/char-literal-parens
Fix opening paren matches with closing paren in character literal
2 parents fbce6dd + b3bbdf0 commit 5715523

File tree

4 files changed

+20
-14
lines changed

4 files changed

+20
-14
lines changed

src/typescript/Scala.tmLanguage.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -583,7 +583,7 @@ export const scalaTmLanguage: TmLanguage = {
583583
name: 'punctuation.definition.character.end.scala'
584584
}
585585
},
586-
name: 'constant.character.literal.scala'
586+
name: 'string.quoted.other constant.character.literal.scala'
587587
},
588588
initialization: {
589589
match: '\\b(new)\\s+([^\\s,\\{\\}\\(\\)\\[\\]]+)',

syntaxes/Scala.tmLanguage.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

tests/snap/lexical.test.scala.snap

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -193,21 +193,21 @@
193193
> ('a', '\u0041', '\n', '\t')
194194
#^^^^ source.scala
195195
# ^ source.scala meta.bracket.scala
196-
# ^ source.scala constant.character.literal.scala punctuation.definition.character.begin.scala
197-
# ^ source.scala constant.character.literal.scala
198-
# ^ source.scala constant.character.literal.scala punctuation.definition.character.end.scala
196+
# ^ source.scala string.quoted.other constant.character.literal.scala punctuation.definition.character.begin.scala
197+
# ^ source.scala string.quoted.other constant.character.literal.scala
198+
# ^ source.scala string.quoted.other constant.character.literal.scala punctuation.definition.character.end.scala
199199
# ^^^^^ source.scala
200-
# ^ source.scala constant.character.literal.scala punctuation.definition.character.begin.scala
201-
# ^^^^^^ source.scala constant.character.literal.scala constant.character.escape.scala
202-
# ^ source.scala constant.character.literal.scala punctuation.definition.character.end.scala
200+
# ^ source.scala string.quoted.other constant.character.literal.scala punctuation.definition.character.begin.scala
201+
# ^^^^^^ source.scala string.quoted.other constant.character.literal.scala constant.character.escape.scala
202+
# ^ source.scala string.quoted.other constant.character.literal.scala punctuation.definition.character.end.scala
203203
# ^^^^^ source.scala
204-
# ^ source.scala constant.character.literal.scala punctuation.definition.character.begin.scala
205-
# ^^ source.scala constant.character.literal.scala constant.character.escape.scala
206-
# ^ source.scala constant.character.literal.scala punctuation.definition.character.end.scala
204+
# ^ source.scala string.quoted.other constant.character.literal.scala punctuation.definition.character.begin.scala
205+
# ^^ source.scala string.quoted.other constant.character.literal.scala constant.character.escape.scala
206+
# ^ source.scala string.quoted.other constant.character.literal.scala punctuation.definition.character.end.scala
207207
# ^^^^^ source.scala
208-
# ^ source.scala constant.character.literal.scala punctuation.definition.character.begin.scala
209-
# ^^ source.scala constant.character.literal.scala constant.character.escape.scala
210-
# ^ source.scala constant.character.literal.scala punctuation.definition.character.end.scala
208+
# ^ source.scala string.quoted.other constant.character.literal.scala punctuation.definition.character.begin.scala
209+
# ^^ source.scala string.quoted.other constant.character.literal.scala constant.character.escape.scala
210+
# ^ source.scala string.quoted.other constant.character.literal.scala punctuation.definition.character.end.scala
211211
# ^ source.scala meta.bracket.scala
212212
>}
213213
#^ source.scala punctuation.section.block.end.scala

tests/unit/lexical.test.scala

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -170,3 +170,9 @@ object Xml {
170170
<authors>{scalaBook.authors.mkList("", ", ", "")}</authors>
171171
</book>
172172
}
173+
174+
class Parens {
175+
capture("layout(" ~ oneOrMore(CharPredicate.All -- ")" -- ')') ~ ")")
176+
// ^ string.quoted.other constant.character.literal.scala
177+
capture("layout(" ~ oneOrMore(CharPredicate.All -- ")" -- `)`) ~ ")")
178+
}

0 commit comments

Comments
 (0)