Update base version to 3.3.1-RC1 #16768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix incorrect tasty version
Kordyjan
commented
Jan 25, 2023
| @@ -289,7 +289,7 @@ object TastyFormat { | |||
| * compatibility, but remains backwards compatible, with all | |||
| * preceeding `MinorVersion`. | |||
| */ | |||
| final val MinorVersion: Int = 2 | |||
| final val MinorVersion: Int = 4 | |||
There was a problem hiding this comment.
During the merge of language-reference-stable, git somehow decided there was no conflict here.
We need to make it impossible for ports from the documentation to change anything except the documentation itself and the scaladoc. I'll try to achieve that later this week.
There was a problem hiding this comment.
This should have been minor version 3.
There was a problem hiding this comment.
Acctualy, I was wrong, this was only used to release 3.4.0-RC1. Therefore the version is correct.
prolativ
reviewed
Jan 25, 2023
| val Interfaces: Seq[ProblemFilter] = Seq( | ||
| ProblemFilters.exclude[MissingClassProblem]("dotty.tools.dotc.interfaces.DiagnosticRelatedInformation"), | ||
| ProblemFilters.exclude[ReversedMissingMethodProblem]("dotty.tools.dotc.interfaces.Diagnostic.diagnosticRelatedInformation") | ||
| ProblemFilters.exclude[ReversedMissingMethodProblem]("dotty.tools.dotc.interfaces.Diagnostic.diagnosticRelatedInformation"), |
There was a problem hiding this comment.
I would expect these exclusions would disappear after the release of 3.3 - not that we would need more for previously added parts of the API
prolativ
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix incorrect tasty version