Hide quote related exceptions from users #10202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
hide-quote-exceptions
branch
from
8f76f9f to
8cf432f
Compare
liufengyun
reviewed
Nov 6, 2020
| @@ -1,4 +1,4 @@ | |||
| package scala.quoted | |||
| package scala.internal.quoted | |||
There was a problem hiding this comment.
What about private? Or use scala.quoted.internal?
There was a problem hiding this comment.
There is one use in the compiler. I will try to remove it and make it private.
There was a problem hiding this comment.
I made it private
nicolasstucki
force-pushed
the
hide-quote-exceptions
branch
3 times, most recently
from
7c0c4ba to
2b19d7b
Compare
Users should never throw or catch these exceptions.
nicolasstucki
force-pushed
the
hide-quote-exceptions
branch
from
2b19d7b to
bc7d9f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users should never throw or catch these exceptions.