Skip to content

dotty scalajs: @JSImport has no effect #9762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aappddeevv opened this issue Sep 9, 2020 · 2 comments
Closed

dotty scalajs: @JSImport has no effect #9762

aappddeevv opened this issue Sep 9, 2020 · 2 comments

Comments

@aappddeevv
Copy link

Problem

I have the working project here: https://github.com/aappddeevv/dotty-scalajs

The import of a node package is in https://github.com/aappddeevv/dotty-scalajs/blob/master/src/main/scala/fetch.scala.

The issue is that @jsimport does not seem to cause the js import (require for a node application) to be issued into the linked file.

Expectation

@JSImport should generate the equivalent js import in the link file.

@sjrd sjrd self-assigned this Sep 10, 2020
@sjrd
Copy link
Member

sjrd commented Sep 10, 2020

I believe this will be fixed by #9725.

@aappddeevv
Copy link
Author

I think this is fixed.

@sjrd sjrd closed this as completed Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants