Skip to content

Extension clause position #8725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolasstucki opened this issue Apr 15, 2020 · 3 comments
Closed

Extension clause position #8725

nicolasstucki opened this issue Apr 15, 2020 · 3 comments
Labels
area:parser area:positions itype:bug

Comments

@nicolasstucki
Copy link
Contributor

The first definition in extension clauses has a wrong position. This may be an issue with semanticdb or the parser.

https://github.com/lampepfl/dotty/blob/master/tests/semanticdb/expect/Givens.expect.scala#L10
@nicolasstucki nicolasstucki mentioned this issue Apr 15, 2020
Merged
@odersky odersky closed this as completed Apr 27, 2020
@nicolasstucki nicolasstucki reopened this Apr 27, 2020
@nicolasstucki
Copy link
Contributor Author

This was not fixed in the PR mentioned above. It was found in it.

@bishabosha
Copy link
Member

This is just an issue with formatting that if some positions overlap then one is printed after the other, what is the real issue is that the position of the extension wrapper class is on the following line

@nicolasstucki
Copy link
Contributor Author

This has been fixed. It is tested with https://github.com/lampepfl/dotty/blob/master/tests/semanticdb/expect/Givens.expect.scala#L10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:parser area:positions itype:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@odersky @nicolasstucki @bishabosha