Skip to content

Port RefChecks fixes from scalac related to linearization #7551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
smarter opened this issue Nov 13, 2019 · 1 comment · Fixed by #12982
Closed

Port RefChecks fixes from scalac related to linearization #7551

smarter opened this issue Nov 13, 2019 · 1 comment · Fixed by #12982
Labels
area:transform compat:scala2 itype:bug
Milestone
3.0.2

Comments

@smarter
Copy link
Member

smarter commented Nov 13, 2019

See scala/scala#7439. For some reason, the test in the original issue (scala/bug#11136) does not crash dotty anymore (see #5094), but we haven't ported any of the changes in scala/scala#7439 yet, so we're probably still accepting some broken things.
@smarter smarter changed the title Port RefChecks fixes from scalac Port RefChecks fixes from scalac related to linearization Nov 13, 2019
@smarter smarter mentioned this issue Mar 15, 2021
Merged
@smarter
Copy link
Member Author

smarter commented Mar 17, 2021

To be precise, the pos testcase added in #7549 should not compile (as in Scala 2) as it means that a final def is overridden by a non-final def, see also discussion in #11741

@smarter smarter mentioned this issue May 12, 2021
Merged
@smarter smarter mentioned this issue Jun 16, 2021
Closed
@smarter smarter mentioned this issue Jun 29, 2021
Merged
@smarter smarter linked a pull request Jul 5, 2021 that will close this issue
Refine overriding pairs in RefChecks #12982
Merged
@Kordyjan Kordyjan added this to the 3.0.2 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:transform compat:scala2 itype:bug
Projects
None yet
Milestone
3.0.2
Development

Successfully merging a pull request may close this issue.

Refine overriding pairs in RefChecks dotty-staging/dotty
2 participants
@smarter @Kordyjan