Skip to content

Bring back some language server rename tests #7234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
odersky opened this issue Sep 16, 2019 · 2 comments
Open

Bring back some language server rename tests #7234

odersky opened this issue Sep 16, 2019 · 2 comments
Assignees
@smarter

Comments

@odersky
Copy link
Contributor

odersky commented Sep 16, 2019

In #7210 I has to disable some rename tests in the language server test suite. The commit is here:
749932a.

The tests broke after an extensive rewrite of the data structures used for imports. I looked for a while but could not find a problem. It would be good if someone who is more current with the language server found out what exactly is wrong.
@nicolasstucki nicolasstucki mentioned this issue Sep 17, 2019
Closed
@smarter
Copy link
Member

smarter commented Sep 17, 2019

Can you point me to the commit with the changes to import ?

@nicolasstucki
Copy link
Contributor

The commit you are looking for is probably bc00dc6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smarter smarter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@smarter @odersky @nicolasstucki