Skip to content

Fix problem in fastparse test #7133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
odersky opened this issue Aug 29, 2019 · 1 comment
Closed

Fix problem in fastparse test #7133

odersky opened this issue Aug 29, 2019 · 1 comment

Comments

@odersky
Copy link
Contributor

odersky commented Aug 29, 2019

With #7130, line 117 in the fastparse test FasterParserParser.scala broke. It's the first commented-out line in the code snippet:

  def arrBody[$: P]: P[Expr] = P(
    Index ~~ expr ~ (compSuffix | "," ~ (compSuffix | (expr.rep(0, sep = ",") ~ ",".?).map(Right(_)))).?
  ).map{
    case (offset, first, None) => Expr.Arr(offset, Seq(first))
    //case (offset, first, Some(Left(comp))) => Expr.Comp(offset, first, comp._1, comp._2)
      // previous line gives an error after #7130:
      //   _1 is not a member of Any (with errors ^^^^ under comp._1)
    case (offset, first, Some(Right(rest))) => Expr.Arr(offset, Seq(first) ++ rest)
  }

We should find out how to fix this.

@liufengyun
Copy link
Contributor

Already fixed in #7161.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants